findViewById in Fragment

Question

I am trying to create an ImageView in a Fragment which will refer to the ImageView element which I have created in the XML for the Fragment. However, the findViewById method only works if I extend an Activity class. Is there anyway of which I can use it in Fragment as well?

public class TestClass extends Fragment { public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { ImageView imageView = (ImageView)findViewById(R.id.my_image); return inflater.inflate(R.layout.testclassfragment, container, false); } }

The findViewById method has an error on it which states that the method is undefined.

Use ButterKnife viewbinding library for android. Also demonstrate how it’s work, how to integrate and use in your android app development to make your development faster. — Samiran
– Samiran, Commented Oct 30, 2018 at 4:37
'Some' time has passed but you still haven't accepted an answer. Can you select the answer that helped you most so this can be marked as answered? — David3103
– David3103, Commented Apr 9, 2019 at 8:45
It is encourages to use Data Binding orang View Binding instead manual findViewById — mochadwi
– mochadwi, Commented Jan 10, 2020 at 11:51

Uddhav P. Gautam · Accepted Answer · 2023-07-15 15:54:25Z

1614

Use getView() or the View parameter from implementing the onViewCreated method. It returns the root view for the fragment (the one returned by onCreateView() method). With this you can call findViewById().

@Override public void onViewCreated(View view, @Nullable Bundle savedInstanceState) { ImageView imageView = (ImageView) getView().findViewById(R.id.foo); // or (ImageView) view.findViewById(R.id.foo); }

As getView() works only after onCreateView(), you can't use it inside onCreate() or onCreateView() methods of the fragment .

edited Jul 15, 2023 at 15:54

Uddhav P. Gautam

7,6843 gold badges52 silver badges68 bronze badges

answered Jun 27, 2011 at 16:34

advantej

20.3k4 gold badges37 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

19 Comments

Dmitry Zaytsev Over a year ago

Note: it's works only after onCreateView(). So, you can't use this in onCreate()

Nico AD Over a year ago

so what is the function I can override to implement this if onCreate is not the right place ?

MattJenko Over a year ago

This doesn't help if the ImageView is coming from the inflated layout - see my answer for details. Otherwise, onCreateView is the right place to do this @N-AccessDev

advantej Over a year ago

The best place to do this the onViewCreated method

Monstieur Over a year ago

The documentation states that onActivityCreated() is the recommended place to find and store references to your views. You must clean up these stored references by setting them back to null in onDestroyView() or you will leak the Activity.

|

JJD · Accepted Answer · 2015-07-02 09:41:24Z

671

You need to inflate the Fragment's view and call findViewById() on the View it returns.

public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View view = inflater.inflate(R.layout.testclassfragment, container, false); ImageView imageView = (ImageView) view.findViewById(R.id.my_image); return view; }

edited Jul 2, 2015 at 9:41

JJD

52.7k63 gold badges218 silver badges352 bronze badges

answered Jun 27, 2011 at 16:35

LeffelMania

12.9k5 gold badges34 silver badges36 bronze badges

11 Comments

Raunak Over a year ago

When you do V.findViewById(R.id.someid),surely that will only work for all the widgets that are in the inflated view. What if the imageView he is trying to inflate is outside the inflated view?

LeffelMania Over a year ago

Then the class that "owns" and inflated the imageView needs to provide public access to it. That is very bad practice though. Fragments should only have access to the UI elements present in their layout.

LeffelMania Over a year ago

Looks like there's something wrong in your code (updating UI from a background thread), not mine.

altumano Over a year ago

Thanks, it was useful. As unrelated comment: try to stick to Java naming conventions in your code. "V" does not look like a variable name in Java.

Machado Over a year ago

This should be the right answer. The accepted one leaves you with NullPointerException.

|

Ankur Chaudhary · Accepted Answer · 2017-07-18 10:51:54Z

Inside Fragment class you will get onViewCreated() override method where you should always initialize your views as in this method you get view object using which you can find your views like :

@Override public void onViewCreated(View view, Bundle savedInstanceState) { super.onViewCreated(view, savedInstanceState); view.findViewById(R.id.yourId).setOnClickListener(this); // or getActivity().findViewById(R.id.yourId).setOnClickListener(this); }

Always remember in case of Fragment that onViewCreated() method will not called automatically if you are returning null or super.onCreateView() from onCreateView() method. It will be called by default in case of ListFragment as ListFragment return FrameLayout by default.

Note: you can get the fragment view anywhere in the class by using getView() once onCreateView() has been executed successfully. i.e.

getView().findViewById("your view id");

I am surprised not a lot of people have upvoted this response--this is the correct way to setup listeners on fragments... Perhaps this was a new development in the API.
Using view passed to onViewCreated still causes NullPointerException but using getActivity() is fine. Any ideas why?
@dVaffection It may be that you are not returning a non null view in onCreateView() lifecycle method of fragment. Now in case of getActivity you are getting views from your activity rather than fragment main view depends upon what id you are passing. Please check are you returning a non null view from onCreateView or not? Then let me know.
@AnkurChaudhary I return view from onCreateView method. I've just debugged and it turns out there is a layout (in my case FrameLayout). That being said when I try to find an element it returns null. Why is it happening?
@dVaffection can you please share your class of fragment and corresponding layout.

Nimantha · Accepted Answer · 2023-11-13 10:51:32Z

69

What is required of imageView - are we passing it back as the view, or merely saving a reference for later?

Either way, if the ImageView is coming from the inflated layout, the correct way to do this would be:

public class TestClass extends Fragment { public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View v = inflater.inflate(R.layout.testclassfragment, container, false); ImageView imageView = (ImageView)v.findViewById(R.id.my_image); return v; } }

edited Nov 13, 2023 at 10:51

Nimantha

6,5376 gold badges32 silver badges78 bronze badges

answered Apr 11, 2013 at 10:46

MattJenko

1,2088 silver badges11 bronze badges

3 Comments

whyoz Over a year ago

How then would you update imageView from ListFragment? Would this require FragmentManager? In other words, how can you update the imageView in a detail fragment from a separate class's onListItemClick?

MattJenko Over a year ago

You would either save a reference to the imageView somewhere handy, or fragment.getView().findViewById(R.id.my_image) when you need it. In a ListFragment, assuming the image is in a list item, you would generally create a reference holder with the setTag/getTag methods of the list view item in your Adapter's getView method - there are many examples of how to do this.

HX_unbanned Over a year ago

@MattJenko, can you share more details or sample how to do have working solution when the inflated layout is used? for instance, i have an viewpager2 with tablayout (4 tabs ) mediated, and I am inflating the edittext views in fragment, and I need to access the editext for each viewpager2's view from main activity. How to do it exactly?

xevincent · Accepted Answer · 2011-06-27 16:35:53Z

55

Get first the fragment view and then get from this view your ImageView.

public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View view = inflater.inflate(R.layout.testclassfragment, container, false); ImageView imageView = (ImageView) view.findViewById(R.id.my_image); return view; }

answered Jun 27, 2011 at 16:35

xevincent

3,74420 silver badges20 bronze badges

4 Comments

Tsunaze Over a year ago

So, does onCreate method is useful in a Fragment ?

xevincent Over a year ago

onCreateView creates and returns the view hierarchy associated with the fragment.onCreate is called to do initial creation of the fragment. Indeed, it depends on what you write in these methods.

Tsunaze Over a year ago

Okay, but how can i declare variable in the onCreate ? Because the View is inside the onCreateView method .

StuStirling Over a year ago

@Tsunaze did you ever find out how to do this from the onCreate method?

Apurv · Accepted Answer · 2019-12-13 15:43:08Z

Inside Fragment class we get onViewCreated() override method where we should always initialize our views because in this method we get view object. Using this object we can find our views like below:

class MyFragment extends Fragment { private ImageView imageView; @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { return inflater.inflate(R.layout.my_fragment_layout, container, false); } @Override public void onViewCreated(View view, Bundle savedInstanceState) { super.onViewCreated(view, savedInstanceState); //initialize your view here for use view.findViewById("your view id") imageView = (ImageView) view.findViewById(R.id.my_image); } }

rafvasq · Accepted Answer · 2018-07-18 18:34:27Z

You could also do it in the onActivityCreated Method.

public void onActivityCreated(Bundle savedInstanceState) { super.onActivityCreated(savedInstanceState); }

Like they do here: http://developer.android.com/reference/android/app/Fragment.html (deprecated in API level 28)

getView().findViewById(R.id.foo);

and

getActivity().findViewById(R.id.foo);

are possible.

Note that API 28 introduces requiereActivity(), requireView(), requireViewById().

conca · Accepted Answer · 2014-11-04 23:25:18Z

21

getView() will give the root view

View v = getView().findViewByID(R.id.x);

edited Nov 4, 2014 at 23:25

conca

1,43410 silver badges10 bronze badges

answered Sep 3, 2014 at 12:41

dreamdeveloper

1,2761 gold badge16 silver badges20 bronze badges

Comments

Community · Accepted Answer · 2016-04-18 12:28:04Z

You can override onViewCreated() which is called right after all views had been inflated. It's the right place to fill in your Fragment's member View variables. Here's an example:

class GalleryFragment extends Fragment { private Gallery gallery; (...) @Override public void onViewCreated(View view, Bundle savedInstanceState) { gallery = (Gallery) view.findViewById(R.id.gallery); gallery.setAdapter(adapter); super.onViewCreated(view, savedInstanceState); } }

Ziem · Accepted Answer · 2016-05-20 12:44:12Z

The method getView() wont work on fragments outside OnCreate and similar methods.

You have two ways, pass the view to the function on the oncreate (what means you can only run your functions when the view is being created) or set the view as a variable:

private View rootView; @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { rootView = inflater.inflate(R.layout.fragment_contatos, container, false); } public void doSomething () { ImageView thumbnail = (ImageView) rootView.findViewById(R.id.someId); }

Nimantha · Accepted Answer · 2023-11-13 10:52:11Z

First inflate layout of Fragment then you can use findviewbyId.

View view = inflater.inflate(R.layout.testclassfragment, container, false); ImageView imageView = (ImageView) view.findViewById(R.id.my_image); return view;

Ziem · Accepted Answer · 2016-05-20 12:44:42Z

EditText name = (EditText) getView().findViewById(R.id.editText1); EditText add = (EditText) getView().findViewById(R.id.editText2);

Kartik · Accepted Answer · 2017-10-08 14:53:05Z

Note :

From API Level 26, you also don't need to specifically cast the result of findViewById as it uses inference for its return type.

So now you can simply do,

public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View view = inflater.inflate(R.layout.testclassfragment, container, false); ImageView imageView = view.findViewById(R.id.my_image); //without casting the return type return view; }

I suggest to combine this answer with one mentioning deprecation of getView() in API 28.

Nimantha · Accepted Answer · 2023-11-13 10:52:46Z

Agreed with calling findViewById() on the View.

public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View V = inflater.inflate(R.layout.testclassfragment, container, false); ImageView imageView = (ImageView) V.findViewById(R.id.my_image); return V; }

Manoj ahirwar · Accepted Answer · 2015-03-29 08:53:56Z

Use

imagebutton = (ImageButton) getActivity().findViewById(R.id.imagebutton1); imageview = (ImageView) getActivity().findViewById(R.id.imageview1);

it will work

Dexter · Accepted Answer · 2014-10-13 02:02:18Z

According to the documentation on API level 11

Reference, in Back Stack http://developer.android.com/reference/android/app/Fragment.html

short code

/** * The Fragment's UI is just a simple text view showing its * instance number. */ @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View v = inflater.inflate(R.layout.hello_world, container, false); View tv = v.findViewById(R.id.text); ((TextView)tv).setText("Fragment #" + mNum); tv.setBackgroundDrawable(getResources().getDrawable(android.R.drawable.gallery_thumb)); return v; }

Chris · Accepted Answer · 2015-01-05 17:41:43Z

9

Using getView() returns the view of the fragment, then you can call findViewById() to access any view element in the fragment view.

edited Jan 5, 2015 at 17:41

Chris

7,35019 gold badges68 silver badges111 bronze badges

answered Jul 11, 2013 at 11:55

Mahmoud Badri

1,31615 silver badges26 bronze badges

1 Comment

Steve M Over a year ago

the view is not the activity

OneCricketeer · Accepted Answer · 2017-06-11 20:01:56Z

Try this it works for me

public class TestClass extends Fragment { private ImageView imageView; public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View view = inflater.inflate(R.layout.testclassfragment, container, false); findViews(view); return view; } private void findViews(View view) { imageView = (ImageView) view.findViewById(R.id.my_image); } }

Yes, this code here is okay. Your edits to the other are not.
I'm sorry I can't quite understand your English, but everything is fixed now. I have nothing to show you.

Nimantha · Accepted Answer · 2023-11-13 10:50:31Z

ImageView imageView; public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View view = inflater.inflate(R.layout.testclassfragment, container, false); imageView = view.findViewById(R.id.my_image); return view; }

Ziem · Accepted Answer · 2016-05-20 12:45:20Z

1) Declare your layout file.

public View onCreateView(LayoutInflater inflater,ViewGroup container, Bundle savedInstanceState) { return inflate(R.layout.myfragment, container, false); }

2)Then, get the id of your view

@Override public void onViewCreated(View view, @Nullable Bundle savedInstanceState) { super.onViewCreated(view, savedInstanceState); TextView nameView = (TextView) view.findViewById(R.id.textview1); }

Ziem · Accepted Answer · 2016-05-20 12:45:52Z

Try This:

View v = inflater.inflate(R.layout.testclassfragment, container, false); ImageView img = (ImageView) v.findViewById(R.id.my_image); return v;

Nimantha · Accepted Answer · 2023-11-13 10:53:19Z

Try

private View myFragmentView; @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { myFragmentView = inflater.inflate(R.layout.myLayoutId, container, false); myView = myFragmentView.findViewById(R.id.myIdTag) return myFragmentView; }

There's no reason for the field. You can always call getView() later

2 revs, 2 users 92% · Accepted Answer · 2023-11-13 10:54:32Z

The best way to implement this is as follows:

public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { rootView = inflater.inflate(R.layout.testclassfragment, container, false); ImageView imageView = (ImageView) rootView.findViewById(R.id.my_image); return rootView }

In this way, the rootView can be used for each control defined in the xml layout and the code is much cleaner in this way.

Ilya Gazman · Accepted Answer · 2015-01-23 22:57:18Z

Use gradle skeleton plugin, it will automatically generate the view holder classes with the reference to your layout.

public class TestClass extends Fragment { public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { MyLayout myLayout = new MyLayout(inflater, container, false); myLayout.myImage.setImageResource(R.drawable.myImage); return myLayout.view; } }

Now assuming you had an ImageView declared in your my_layout.xml file, it will automatically generate myLayout class for you.

Vasia Zaretskyi · Accepted Answer · 2020-10-08 20:22:15Z

I like everything to be structured. You can do in this way.

First initialize view

private ImageView imageView;

Then override OnViewCreated

@Override public void onViewCreated(View view, @Nullable Bundle savedInstanceState) { super.onViewCreated(view, savedInstanceState); findViews(view); }

Then add a void method to find views

private void findViews(View v) { imageView = v.findViewById(R.id.img); }

Mazhar Iqbal · Accepted Answer · 2021-03-25 07:24:26Z

//here you can do it by public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { // Inflate the layout for this fragment final View view = inflater.inflate(R.layout.fragment_apple, container, false); ist = view.findViewById(R.id.linearLink); second = view.findViewById(R.id.linearPhone); return view;

LateSLM · Accepted Answer · 2014-08-06 15:31:39Z

You can call findViewById() with the Activity Object you get inside your public void onAttach(Activity activity) method inside your Fragment.

Save the Activity into a variable for example:

In the Fragment class: private Activity mainActivity; In the onAttach() method: this.mainActivity=activity;

Finally execute every findViewById through the vairable: mainActivity.findViewById(R.id.TextView);

Jorgesys · Accepted Answer · 2016-01-17 03:05:18Z

Inside onCreateView method

1) first you have to inflate the layout/view you want to add eg. LinearLayout

LinearLayout ll = inflater.inflate(R.layout.testclassfragment, container, false);

2) Then you can find your imageView id from layout

ImageView imageView = (ImageView)ll.findViewById(R.id.my_image);

3)return the inflated layout

return ll;

Surajit Mondal · Accepted Answer · 2016-05-20 12:45:01Z

You have to inflate the view

public class TestClass extends Fragment { public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View v = inflater.inflate(R.layout.testclassfragment, container, false); ImageView imageView = (ImageView)v.findViewById(R.id.my_image); return v }}

Ziem · Accepted Answer · 2016-05-20 12:45:39Z

There is one more method called onViewCreated.

@Override public void onViewCreated(View view, @Nullable Bundle savedInstanceState) { super.onViewCreated(view, savedInstanceState); ImageView imageView = (ImageView) view.findViewById(R.id.imageview1); }

Collectives™ on Stack Overflow

findViewById in Fragment

37 Answers 37

19 Comments

11 Comments

10 Comments

3 Comments

4 Comments

Comments

1 Comment

Comments

Comments

Comments

Comments

Comments

2 Comments

Comments

Comments

Comments

1 Comment

2 Comments

Comments

Comments

Comments

1 Comment

1 Comment

Comments

Comments

Comments

Comments

1 Comment

Comments

Comments

Hot Network Questions