write a string into file

Question

I have the above code. What i wanna do is to write in a txt file a string.

 import java.io.*; import java.util.*; public void writeAsfalizomenos(asfalizomenos myObj) throws IOException { Scanner scanner = new Scanner(System.in); System.out.print("Surname: "); String username = scanner.nextLine(); System.out.println(username); FileWriter outFile = new FileWriter("asdf.txt", true); PrintWriter out1 = new PrintWriter(outFile); out1.append(username); out1.println(); out1.append("adfdas"); // // Read string input for username // } public static void main(String [] args) throws IOException{ asfalizomenos a = new asfalizomenos(); a.writeAsfalizomenos(a); }

The above code creates a txt file but it doesnt write the string to it. Any idea about my bug??

If you plan to write a lot of text, the java api recommends wrapping your PrintWriter in a BufferedWriter. There is a code sample in the api itself. download.oracle.com/javase/1.4.2/docs/api/java/io/… As others have point out, you are not closing your PrintWriter — Ali
– Ali, Commented Aug 10, 2011 at 22:21

Jon Skeet · Accepted Answer · 2011-08-10 22:14:44Z

You're not closing or flushing the PrinterWriter or the FileWriter. So basically it's being buffered, so nothing is being written to the file.

You should close both in finally blocks:

FileWriter outFile = new FileWriter("asdf.txt", true); try { PrintWriter out1 = new PrintWriter(outFile); try { out1.append(username); out1.println(); out1.append("adfdas"); } finally { out1.close(); } } finally { outFile.close(); }

Closing will flush automatically.

(I can't remember - it's likely that closing the PrintWriter will close the FileWriter. Personally I like to be explicit about it anyway.)

Yeah man thanks. The printerwriter is the one that must close.
@snake: As I say, that should close the FileWriter too - but personally I would close both. I'd also use FileOutputStream wrapped in an OutputStreamWriter, specifying the encoding, but that's a separate matter.

tskuzzy · Accepted Answer · 2011-08-10 22:15:02Z

1

Close the PrintWriter after you're done writing to it:

out1.close();

answered Aug 10, 2011 at 22:15

tskuzzy

36.6k15 gold badges78 silver badges145 bronze badges

Collectives™ on Stack Overflow

write a string into file

2 Answers 2

2 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Linked

Related