How to erase certain element of a vector of pointers

Question

Hello i'm curently coding a fonction that erase element from a vector of pointer(to class object), but i cant quite make it work.

I get this error error: no matching function for call to ‘std::vector<biblio::Reference*>::erase(biblio::Reference*&)’

std::vector<Reference*> m_vReferences; //Reference is a class

for ( auto iter : m_vReferences) //Loop for on every pointer to a class object { if (iter->reqId () == p_id) //Check if the id of the class object is the id we want { m_vReferences.erase (iter); //Erase the pointer in the vector of pointer } else { throw EmptyReferenceException (iter->reqFormatedReference ()); //An exception } }

en.cppreference.com/w/cpp/container/vector/erase takes an iterator, you're giving it an element. — Passerby
– Passerby, Commented Dec 8, 2021 at 22:41
Vector does not support erasing by keys, cause there are no keys. — Quimby
– Quimby, Commented Dec 8, 2021 at 22:41
for ( auto iter : m_vReferences) is an example of bad naming. iter variable is not an iterator, it is an object of type Biblio::Reference*. — SergeyA
– SergeyA, Commented Dec 8, 2021 at 22:49
worse... it's an UB. erase returns new iterator, iterator given to it becomes invalid and shouldn't be incremented — Swift - Friday Pie
– Swift - Friday Pie, Commented Dec 8, 2021 at 23:56

MonteChrist0 · Accepted Answer · 2021-12-09 00:12:00Z

Don't use auto-range loops when you want to delete the element from the container. I would use std::remove_if as it is available in standard library.

m_vReferences.erase(std::remove_if(m_vReferences.begin(),m_vReferences.end(),[p_id](Reference* x){ return x->reqId() == p_id; }),m_vReferences.end());

or you may loop through vector find at which index is the element you want to delete and use erase function from vector.

Collectives™ on Stack Overflow

How to erase certain element of a vector of pointers

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related