assertion in java

Question

i have created an assertion line as below

String title = "A"; int year = 2009; String director = "Zebra";

VideoObj a = new VideoObj(title, year, director);

Assert.assertFalse(a.equals(new VideoObj(title+"1", year,director)));

why does this fail?? the equal method is below.

public boolean equals(Object thatObject) { if (!(thatObject instanceof VideoObj)) return false; VideoObj that = (VideoObj) thatObject; return ((_title.equals(that.title())) && (_director.equals(that.director())) && (_year == that.year())); }

but the below statement

Assert.assertFalse(a.equals(new VideoObj(title, year, director + "1")));

does not fail? can some one explain why the first assert statement fail and not the second?

Please show a short but complete program demonstrating your problem. In particular, that's a bizarre equality method. — Jon Skeet
– Jon Skeet, Commented Jan 29, 2012 at 19:53
Does the predicate still fail to deliver the expected result after correcting the change to &&? And why is the year not germane to equivalence? — seh
– seh, Commented Jan 29, 2012 at 20:34
it works now, but y didn't it go through if it were a ||???? — anisha
– anisha, Commented Jan 29, 2012 at 21:38

NPE · Accepted Answer · 2012-01-29 19:52:52Z

You probably meant to use && instead of || in:

 return ((_title.equals(that.title())) || (_director.equals(that.director())) || (_year == that.year()));

Otherwise you're checking that any of title, director or year are the same, not that all of them are.

Jan · Accepted Answer · 2012-01-29 19:55:12Z

Shouldn't it rather be ((_title.equals(that.title())) && (_director.equals(that.director())) && (_year == that.year()))

Two videos are equal if title AND year AND director is equal, not when only 1 of them is...

Collectives™ on Stack Overflow

assertion in java

2 Answers 2

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Related