Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4066
What is this PR about?
Please describe in a short paragraph what this PR is about.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #4066
Screenshots (if applicable)
Greptile Summary
This PR fixes an oversight in
cloneGiteaRepositorywheregiteaProvider.giteaUrlwas used directly instead of preferringgiteaProvider.giteaInternalUrlwhen available. Every other network-call site in the same file (refreshGiteaToken,testGiteaConnection,getGiteaRepositories,getGiteaBranches) already applied thegiteaInternalUrl || giteaUrlfallback pattern, so this was the only remaining inconsistency, causing git clones to fail or bypass the internal network path when Gitea is co-hosted with Dokploy.buildGiteaCloneUrlis now called withgiteaProvider.giteaInternalUrl || giteaProvider.giteaUrl, matching the pattern used everywhere else in the file.giteaInternalUrlistext | nullin the schema, so the||fallback correctly resolves togiteaUrlwhen it isnullor unset. No type or runtime issues.Confidence Score: 5/5
cloneGiteaRepositoryin line with every other function in the same file. The fallback logic (null || giteaUrl) is idiomatic and correct. No new behaviour is introduced whengiteaInternalUrlis unset.Reviews (1): Last reviewed commit: "Update gitea.ts" | Re-trigger Greptile
(2/5) Greptile learns from your feedback when you react with thumbs up/down!