refac: replace print calls with str-returning format_* methods#621
Open
refac: replace print calls with str-returning format_* methods#621
Conversation
Add format_labels (Constraints, Variables) and format_infeasibilities (Model) that return strings instead of printing to stdout. Deprecate the old print_labels and print_infeasibilities methods with warnings pointing callers to the new alternatives. Closes #476 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
FabianHofmann requested changes Mar 20, 2026
Collaborator
FabianHofmann left a comment
FabianHofmann left a comment There was a problem hiding this comment.
makes sense, would you mind to also align rename the function print_single_constraint accordingly?
Align internal helper naming with the format_* convention introduced for the public API methods. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Rename print_coord, print_single_variable, print_single_expression, and print_line to use the format_* naming convention consistently. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator Author
| @FabianHofmann Done. ALso aligned other purely internal methods to the naming scheme ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format_labels()onConstraintsandVariablesthat return strings instead of printing to stdoutformat_infeasibilities()onModelthat returns a string representation of infeasible constraintsprint_labels()andprint_infeasibilities()withDeprecationWarningpointing to the new methodsCloses #476
Test plan
🤖 Generated with Claude Code