Auto-assign beacons to recipes before modules.#201
Open
DaleStan wants to merge 1 commit intoShadowTheAge:masterfrom
Open
Auto-assign beacons to recipes before modules.#201DaleStan wants to merge 1 commit intoShadowTheAge:masterfrom
DaleStan wants to merge 1 commit intoShadowTheAge:masterfrom
Conversation
This way, effectivity modules will fill to the limit or to the point of counteracting the beacons' effects, rather than stopping at 80% of the 0-beacon consumption.
shpaass added a commit to shpaass/yafc-ce that referenced this pull request May 10, 2024
This way, effectivity modules will fill to the limit or to the point of counteracting the beacons' effects, rather than stopping at 80% of the 0-beacon consumption. In the attached IR3 yafc file (save also attached) the original behavior incorrectly auto-assigned two EFF 3 modules to the recipe, when it should have received four. The recipe should get four modules because there are four speed beacons also affecting the building, substantially increasing its consumption. Switching the order to assign beacons first causes the EFF modules to get auto-added correctly. [IR test.zip](https://github.com/have-fun-was-taken/yafc-ce/files/15268818/IR.test.zip) [IR3 game.zip](https://github.com/have-fun-was-taken/yafc-ce/files/15268826/IR3.game.zip) (This is rebased from ShadowTheAge#201)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, effectivity modules will fill to the limit or to the point of counteracting the beacons' effects, rather than stopping at 80% of the 0-beacon consumption.
In the attached IR3 yafc file (save also attached) the original behavior incorrectly auto-assigned two EFF 3 modules to the recipe, when it should have received four. The recipe should get four modules because there are four speed beacons also affecting the building, substantially increasing its consumption. Switching the order to assign beacons first causes the EFF modules to get auto-added correctly.
IR test.yafc.zip
IR3 game.zip