Skip to content

feat: update docker secret handling to use .dockerconfigjson format.#4489

Open
leozhang2018 wants to merge 1 commit intokoderover:mainfrom
leozhang2018:update-secret-type
Open

feat: update docker secret handling to use .dockerconfigjson format.#4489
leozhang2018 wants to merge 1 commit intokoderover:mainfrom
leozhang2018:update-secret-type

Conversation

@leozhang2018
Copy link
Copy Markdown
Collaborator

@leozhang2018 leozhang2018 commented Jan 29, 2026

What this PR does / Why we need it:

  • Changed the format of Docker configuration from .dockercfg to .dockerconfigjson in CreateOrUpdateRegistrySecret and createOrUpdateRegistrySecrets functions.
  • Updated the secret type from corev1.SecretTypeDockercfg to corev1.SecretTypeDockerConfigJson.
  • Enhanced UpdateOrCreateSecret function to handle immutable secret types by deleting and recreating the secret if the type changes.

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue
@leozhang2018
feat: update Docker secret handling to use .dockerconfigjson format.
32b964c 
Signed-off-by: leozhang2018 <leozhang2018@gmail.com>
@leozhang2018 leozhang2018 added the enhancement New feature or request label Jan 29, 2026
@leozhang2018 leozhang2018 changed the title feat: update Docker secret handling to use .dockerconfigjson format. feat: update docker secret handling to use .dockerconfigjson format. Jan 29, 2026
@leozhang2018
Copy link
Copy Markdown
Collaborator Author

leozhang2018 commented Mar 11, 2026

Preparing review...
1 similar comment
@leozhang2018
Copy link
Copy Markdown
Collaborator Author

leozhang2018 commented Mar 11, 2026

Preparing review...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common enhancement New feature or request service/aslan

1 participant

@leozhang2018