Skip to content

allow stop test speaker#592

Open
romainlq wants to merge 2 commits intoottomated:masterfrom
romainlq:feature/allow-stop-test-speaker
Open

allow stop test speaker#592
romainlq wants to merge 2 commits intoottomated:masterfrom
romainlq:feature/allow-stop-test-speaker

Conversation

@romainlq
Copy link
Copy Markdown

@romainlq romainlq commented Jan 20, 2021 •
edited
Loading

I added the possibility to stop the test speaker as soon as it started playing.

Closes #591
@OhMyGuus
Copy link
Copy Markdown
Contributor

OhMyGuus commented Jan 22, 2021 •
edited
Loading

You should add:
audio.onended = () => { setPlaying(false); };
Because u forgot to reset the button when the sound stopped, for the rest nice.
@romainlq
Copy link
Copy Markdown
Author

romainlq commented Jan 28, 2021

thanks for the feedback @OhMyGuus !
It has been fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@romainlq @OhMyGuus