Skip to content

find: Fix -execdir + working incorrectly for the root path#533

Open
milkory wants to merge 3 commits intouutils:mainfrom
milkory:fix-exec-m-at-root
Open

find: Fix -execdir + working incorrectly for the root path#533
milkory wants to merge 3 commits intouutils:mainfrom
milkory:fix-exec-m-at-root

Conversation

@milkory
Copy link
Contributor

@milkory milkory commented Apr 9, 2025

This command should work now.

find / -maxdepth 0 -execdir echo {} + 
@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (a571de6) to head (d02dcbc).

Additional details and impacted files
@@ Coverage Diff @@ ## main #533 +/- ## ========================================== + Coverage 87.70% 87.77% +0.06%  ========================================== Files 31 31 Lines 6887 6926 +39 Branches 324 324 ========================================== + Hits 6040 6079 +39  Misses 616 616 Partials 231 231 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@milkory milkory changed the title find: Fix -exec + working incorrectly for the root path find: Fix -execdir + working incorrectly for the root path Apr 9, 2025
@sylvestre
Copy link
Contributor

Could you please add a test to make sure we don't regress? Thanks

Copy link
Contributor

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a test

@milkory
Copy link
Contributor Author

milkory commented Apr 13, 2025

Yes, I'll add some later.

@milkory
Copy link
Contributor Author

milkory commented Apr 13, 2025

I have added a test on process_dir and another test for execdir + in root directory.

@milkory milkory requested a review from sylvestre April 13, 2025 16:40
@sylvestre sylvestre force-pushed the fix-exec-m-at-root branch from ca59d98 to d02dcbc Compare April 24, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants