fix promise detection#30
Open
chocolateboy wants to merge 1 commit intovictorb:masterfrom
chocolateboy:is-promise
Open
fix promise detection#30chocolateboy wants to merge 1 commit intovictorb:masterfrom chocolateboy:is-promise
chocolateboy wants to merge 1 commit intovictorb:masterfrom
chocolateboy:is-promise
Conversation
functions are objects and are valid thenables: "promise" is an object or function with a then method whose behavior conforms to this specification. [1] use is-promise to detect promises rather than reimplementing it buggily. [1] https://promisesaplus.com/#terminology
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions are objects and are valid thenables:
This PR uses is-promise to detect promises in a spec-compliant way.
[1] https://promisesaplus.com/#terminology