Closed Bug 2011449 Opened 1 month ago Closed 1 month ago
Add newtab activation window experiment messaging variants
Categories
(Firefox :: New Tab Page, task)
Firefox
New Tab Page
Tracking
()
RESOLVED FIXED
149 Branch
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Whiteboard: [hnt])
Attachments
(4 files)
Experiment documentation: https://docs.google.com/document/d/1aofnTee0dLqu41ODP38MILmyUcW5EYwkcFlWebRm8x0/edit?tab=t.0
We'll want to add the various treatments and ensure any requisite telemetry has been properly added to test effectiveness.
 | Assignee | |
Updated•1 month ago |
Whiteboard: [hnt]
 | ||
Updated•1 month ago |
| | Assignee | |
Comment 1•1 month ago | ||
This was due to a bug in how "data: false" was being interpreted (a false value for data on an action causes
it to not actually be dispatched via the Redux store!)
| | Assignee | |
Comment 2•1 month ago | ||
| | Assignee | |
Comment 3•1 month ago | ||
| | Assignee | |
Comment 4•1 month ago | ||
 | ||
Updated•1 month ago |
Attachment #9540738 - Attachment description: WIP: Bug 2011449 - Part 1: Make it so that newtab messages don't reappear on next load when dismissed. r?#home-newtab-reviewers! → Bug 2011449 - Part 1: Make it so that newtab messages don't reappear on next load when dismissed. r?#home-newtab-reviewers!
| | ||
Updated•1 month ago |
Attachment #9540739 - Attachment description: WIP: Bug 2011449 - Part 2: Add activation window message component. r?#home-newtab-reviewers! → Bug 2011449 - Part 2: Add activation window message component. r?#home-newtab-reviewers!
| | ||
Updated•1 month ago |
Attachment #9540740 - Attachment description: WIP: Bug 2011449 - Part 3: Add CSS rule for variant a and b that keep the customize button expanded. r?#home-newtab-reviewers! → Bug 2011449 - Part 3: Add CSS rule for variant a and b that keep the customize button expanded. r?#home-newtab-reviewers!
| | ||
Updated•1 month ago |
Attachment #9540741 - Attachment description: WIP: Bug 2011449 - Part 4: Add documentation for newtab activation window mechanism. r?#home-newtab-reviewers! → Bug 2011449 - Part 4: Add documentation for newtab activation window mechanism. r?#home-newtab-reviewers!
Pushed by mconley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/faff9b8da4e1 https://hg.mozilla.org/integration/autoland/rev/dc21404612da Part 1: Make it so that newtab messages don't reappear on next load when dismissed. r=home-newtab-reviewers,nbarrett https://github.com/mozilla-firefox/firefox/commit/2014c0ecbe74 https://hg.mozilla.org/integration/autoland/rev/e9d72edb3290 Part 2: Add activation window message component. r=home-newtab-reviewers,fluent-reviewers,omc-reviewers,bolsson,frontend-codestyle-reviewers,nbarrett,emcminn https://github.com/mozilla-firefox/firefox/commit/ee8077d00d93 https://hg.mozilla.org/integration/autoland/rev/de65066b749e Part 3: Add CSS rule for variant a and b that keep the customize button expanded. r=home-newtab-reviewers,thecount https://github.com/mozilla-firefox/firefox/commit/f51b2a501aaa https://hg.mozilla.org/integration/autoland/rev/c38700115dd8 Part 4: Add documentation for newtab activation window mechanism. r=home-newtab-reviewers,nbarrett
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/81cd862538be https://hg.mozilla.org/integration/autoland/rev/73cbf17ce89d Revert "Bug 2011449 - Part 4: Add documentation for newtab activation window mechanism. r=home-newtab-reviewers,nbarrett" for causing failures at activity-stream.css.
 | ||
Comment 7•1 month ago | ||
Backed out for causing failures at activity-stream.css.
Backout link: https://hg.mozilla.org/integration/autoland/rev/73cbf17ce89d
Failure log: https://treeherder.mozilla.org/logviewer?job_id=547079395&repo=autoland&task=cW6ZXa62QLuBZUEcWtbLhg.0&lineNumber=321
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/780d429ee75b https://hg.mozilla.org/integration/autoland/rev/18c9067fefef Part 1: Make it so that newtab messages don't reappear on next load when dismissed. r=home-newtab-reviewers,nbarrett https://github.com/mozilla-firefox/firefox/commit/cc071f21ecbf https://hg.mozilla.org/integration/autoland/rev/e679c252e44e Part 2: Add activation window message component. r=home-newtab-reviewers,fluent-reviewers,omc-reviewers,bolsson,frontend-codestyle-reviewers,nbarrett,emcminn https://github.com/mozilla-firefox/firefox/commit/980566fe738f https://hg.mozilla.org/integration/autoland/rev/4064c0fe407c Part 3: Add CSS rule for variant a and b that keep the customize button expanded. r=home-newtab-reviewers,thecount https://github.com/mozilla-firefox/firefox/commit/a7fbe20b935b https://hg.mozilla.org/integration/autoland/rev/d9c3a175ee12 Part 4: Add documentation for newtab activation window mechanism. r=home-newtab-reviewers,nbarrett
https://hg.mozilla.org/mozilla-central/rev/18c9067fefef
https://hg.mozilla.org/mozilla-central/rev/e679c252e44e
https://hg.mozilla.org/mozilla-central/rev/4064c0fe407c
https://hg.mozilla.org/mozilla-central/rev/d9c3a175ee12
Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox149: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
| | Assignee | |
Updated•1 month ago |
Flags: needinfo?(mconley)
 | ||
Updated•21 days ago |
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in before you can comment on or make changes to this bug.
Description
•