• Joined on 2024-06-29
mathstuf opened issue valpackett/podfox#8 2026-03-17 04:59:03 +01:00
Version query
mathstuf commented on pull request mergiraf/mergiraf#728 2026-03-11 02:29:16 +01:00
(WIP) add ci workflow with nix

At $DAYJOB, we have an org for the project and tag images as ci-$distro-$version-$arch-YYYYMMDD[.N] (or drop-$arch and use manifest images with multiple arches available under a single tag).…

mathstuf commented on pull request mergiraf/mergiraf#728 2026-03-10 15:27:08 +01:00
(WIP) add ci workflow with nix

Does Forgejo have a container registry?

mathstuf commented on pull request mergiraf/mergiraf#719 2026-02-23 15:10:39 +01:00
disable integration test in nix build

Does this test end up playing with the state of the Git repo? That's going to conflict with any other test also wanting to do that. We have a crate that [sets of a "workarea"](https://gitlab.kitwar

mathstuf commented on pull request mergiraf/mergiraf#716 2026-02-22 02:11:57 +01:00
doc: document Git attributes used/recognized by Mergiraf

I think this is fine, thanks.

mathstuf commented on pull request mergiraf/mergiraf#716 2026-02-18 21:48:48 +01:00
doc: document Git attributes used/recognized by Mergiraf

I see it as a way to tell mergiraf the language to use. If you also use linguist-language, that is also looked up as a fallback so that mergiraf.language isn't needed.

mathstuf commented on pull request mergiraf/mergiraf#716 2026-02-17 03:10:24 +01:00
doc: document Git attributes used/recognized by Mergiraf

No idea what happened; the original comment is gone :/ . I blame early morning intersecting Codeberg unfamiliarity.

mathstuf commented on pull request mergiraf/mergiraf#716 2026-02-17 03:09:24 +01:00
doc: document Git attributes used/recognized by Mergiraf

This paragraph can be removed if the list is sorted and introduced with …for this purpose, in order:

mathstuf suggested changes for mergiraf/mergiraf#716 2026-02-16 06:11:10 +01:00
doc: document Git attributes used/recognized by Mergiraf

Minor request. Looks good other than that!

mathstuf commented on pull request mergiraf/mergiraf#704 2026-02-11 04:49:53 +01:00
ci: warn against uses of dbg!

That's probably fine for now; I don't expect any #cfg blocks in the project to suddenly start showing up (CMake definitely has files that don't get compiled on each platform…and doing things…

mathstuf commented on pull request mergiraf/mergiraf#704 2026-02-10 15:55:28 +01:00
ci: warn against uses of dbg!

Clippy enforcement in CI is great. I am suggesting tools for easing fixing it for developers.

mathstuf commented on pull request mergiraf/mergiraf#704 2026-02-09 22:28:16 +01:00
ci: warn against uses of dbg!

Recording a Vim macro :) . Finds the next instance, deletes to the (, then deletes the surrounding (.

mathstuf commented on pull request mergiraf/mergiraf#704 2026-02-09 21:35:08 +01:00
ci: warn against uses of dbg!
mathstuf commented on pull request mergiraf/mergiraf#704 2026-02-09 20:33:27 +01:00
ci: warn against uses of dbg!

There's no general way to know that. I suppose for a token or path thereof, you can, but dbg!(some_call()); shouldn't be taken away completely. At that point though, your diff is something like:

mathstuf commented on pull request mergiraf/mergiraf#704 2026-02-09 17:15:12 +01:00
ci: warn against uses of dbg!

Is --tests included in --all-features or is CI blind to clippy lints in test code here?

mathstuf commented on pull request mergiraf/mergiraf#704 2026-02-09 17:12:49 +01:00
ci: warn against uses of dbg!

The main benefit, IMO, is that ast-grep is blind to #[cfg] bits, so it also always gets the dbg! calls from your tests too. I imagine the suggested command line also fails to forward…

mathstuf approved mergiraf/mergiraf#704 2026-02-09 15:34:05 +01:00
ci: warn against uses of dbg!

I wrote an ast-grep fixit to do this automatically for CMake here. Shouldn't be too hard to…