Address geocoder

Got a little carried away, but here's my take. Haven't been able to test it though, so consider it more as a draft of a different approach, than a drop-in replacement (although if it just works, that's cool too).

Basically, I've DRY'ed the code as much as I could, breaking the logic into several functions, so the final event handlers are as straightforward as possible. I also ran with the fact that you've ID'ed your elements with the names of the values you want them to display, just prefixed with shop_.

$(function () { // Get all the elements once and for all var elements = (function () { var elements = {}; $.each(["lat", "lng", "street_address", "route", "intersection", "formatted_address"], function (id) { elements[id] = $("#shop_" + id); }); return elements; }()); // Generic result-extraction function // Takes an array of results, and an array of the address component // types it should collect function extract(results, types) { // Internal function to extract the address components function extractAddressComponents(result) { var i, l, address, type, extracted = {}; for( i = 0, l = result.address_components.length ; i < l ; i++ ) { address = result.address_components[i]; type = address.types[0]; // Uncomment this next line, if you want to avoid what user1689607 mentions in the comments // if( extracted[type] ) { continue } if( types.indexOf(type) !== -1 ) { extracted[type] = address.long_name; } } return extracted; } return $.map(results, function (result) { $.extend({ label: result.formatted_address, value: result.formatted_address, lat: result.geometry.location.lat(), lng: result.geometry.location.lng(), latlng: result.geometry.location, formatted_address: result.formatted_address }, extractAddressComponents(result)); }); } // Function to set the values of the elements function populate(obj) { var id; for( id in elements ) { if( !elements.hasOwnProperty(id) ) { continue; } if( obj.hasOwnProperty(id) ) { elements[id].val(obj[id]); } else { elements[id].val(""); } } } // Center the map and marker function center(latlng) { if( latlng ) { marker.setPosition(latlng); map.setCenter(latlng); } } // A little convenience wrapping of the geocoding functions var geocode = (function () { function geocode(query, callback) { geocoder.geocode(query, function (results, status) { if( status === google.maps.GeocoderStatus.OK ) { callback(extract(results, ["street_address", "route", "intersection"])); } else { callback([]); } }); } return { address: function (address, callback) { geocode({address: address}, callback); }, reverse: function (latlng, callback) { geocode({latLng: latlng}, callback); } }; }()); // Hook it all up here elements.formatted_address.autocomplete({ source: function(request, response) { response(geocode.address(request.term)); }, select: function (event, ui) { clearValue(); // Don't know what this one does, but I left it in delete ui.item.formatted_address; populate(ui.item); center(ui.item.latlng); }, focus: function (event, ui) { center(ui.item.latlng); } }); google.maps.event.addListener(marker, 'drag', function() { var latlng = marker.getPosition(), results = geocode.reverse(latlng), result; clearValue(); // Don't know what this one does, but I left it in if( results.length ) { result = results[0]; $.extend(result, { lat: latlng.lat(), lng: latlng.lng() }); populate(result); } else { alert('No results found. Please revise the address or adjust the map marker.'); } }); }); 

In the end there's more code, but hopefully it'll seem cleaner, and be more maintainable. And there's very, very little repetition, which I believe is what you originally asked for (as I said, I got carried away).