Theme preview model and Media library model having issues with Shift/Ctrl + Shift next and previous arrows.

[praful2111]

When we open the theme preview model and try to select text using the Shift/Ctrl+Shift with a left and right arrow then the theme modal switches the theme instead of the selecting text.

Screen recording - ​https://www.awesomescreenshot.com/video/37791980

[praful2111]

Patch added

[praful2111]

Patch added

[praful2111]

Screen recording - ​https://www.awesomescreenshot.com/video/37791980?key=1d6a6270a28dec655a193a49300f5d43

[hiteshtalpada]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/63126/63126.patch

Environment

• WordPress: 6.8-beta3-60042-src
• PHP: 8.2.25
• Server: nginx/1.27.2
• Database: mysqli (Server: 8.4.2 / Client: mysqlnd 8.2.25)
• Browser: Chrome 134.0.0.0
• OS: Linux
• Theme: Twenty Twenty-Five 1.1
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

[joemcgill]

Hi @praful2111. Thanks for the report and for including a patch!

I can reproduce the issue and confirmed that this was existing behavior in 6.7. Given that we're so close to the release deadline for 6.8, I'm adding this to the 6.9 milestone for consideration.

[joedolson]

The same issue occurs in the media library modal. We can probably resolve both in this ticket; but if it proves to be a significantly different solution, we should open a separate ticket.

[hiteshtalpada]

Hi @joedolson Thanks for pointing that out!

I've created a patch that should resolve the issue in the media library model.

[hiteshtalpada]

Added theme and media library model patch

[nazmul111]

Replying to praful2111:

Screen recording - ​https://www.awesomescreenshot.com/video/37791980

screen recording not found. You are requested to check.

[sandeepdahiya]

Bug Reproduction and Test Report

Description

✅ This report validates that the bug exists as reported and the indicated patch works as expected.

Patch tested: 63126-theme-and-edit-attachments.patch

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.28
• Server: nginx/1.27.5
• Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
• Browser: Firefox 139.0
• OS: Windows 10/11
• Theme: Twenty Twenty-Five 1.2
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. 🐞 Bug reproduction: Log in to the WordPress dashboard, go to Appearance → Themes, click on any theme, and try selecting text using the mouse. Then use (Shift + →) or (Ctrl + Shift + →).You’ll notice that instead of selecting the text, WordPress navigates to the next theme preview. The same issue occurs in the Media Library as well.

2. ✅ Test results: Issue resolved with patch. (Shift + →) or (Ctrl + Shift + →) selects the next instead of moving to the next item. and pressing → key only takes you to the next item.

Additional Notes

• ​Bug Reproduction video . Note: I have pressed (Shift + →) or (Ctrl + Shift + →)
• ​Patch Test video. Note: I have pressed (Shift + →) or (Ctrl + Shift + →)

This PR prevents theme preview and media library modals from interfering with text selection keyboard shortcuts.

When using Shift+Arrow or Ctrl+Shift+Arrow to select text in modal descriptions, the modal would capture the arrow keys and navigate to next/previous items instead of allowing text selection. This unexpected behavior prevented users from efficiently editing text.

Added tests to verify the logic to ignore arrow key events when Shift or Ctrl+Shift modifiers are pressed, allowing default text selection behavior.

Follows Patch: https://core.trac.wordpress.org/attachment/ticket/63126/63126-theme-and-edit-attachments.patch

I briefly considered whether the tests should use event.code or event.key instead of the deprecated event.keyCode, but decided that it makes more sense to keep the tests using the same references used in the actual code, and changing those over should be a separate task.

[joedolson]

In 60516:

General: Prevent Media & Theme modals from events on modified arrow keys.

Change the left and right arrow key navigation used in the Theme and Media modal interfaces so the events don't fire when shift or ctrl are also pressed.

Includes tests.

Props praful2111, hiteshtalpada, joemcgill, sandeepdahiya, abcd95, joedolson.
Fixes #63126.