Do not MERGE : Audit Fixes 10: Insufficient validation of the input URLs #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Deploying abstract-docs with |
| Latest commit: | b985d4f |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a40d8a32.abstract-docs.pages.dev |
| Branch Preview URL: | https://audit-fixes-10-insufficient.abstract-docs.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
adairrr reviewed Nov 27, 2024
Comment on lines +33 to +34
| } else if let Err(e) = Url::parse(link) { | ||
| Err(ValidationError::LinkInvalidUrl(e)) |
Contributor
There was a problem hiding this comment.
The reason we didn't do this Url verification from the original audit results last year was because of wasm size increase with minimal benefit. Would you mind checking the size differences before and after?
Contributor Author
There was a problem hiding this comment.
The increase is ~ 160K, this is huge !
We might not want to merge that PR
Kayanski changed the title Contributor Author
| Closed because there is a 160K increase in wasm size because of this change alone |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist