Skip to content

Conversation

@Buckram123
Copy link
Collaborator

@Buckram123 Buckram123 commented Apr 24, 2025

This PR aims to add support for multiple polytone connections on ica-client.

Implementation inspired by ibc-client

@Buckram123 Buckram123 requested a review from Kayanski April 24, 2025 11:48
@Buckram123
Copy link
Collaborator Author

Buckram123 commented Apr 24, 2025

Up for discussion: It seems more common to use chain id as number instead of chain-name for evm chains, do we want to replace TruncatedChainId parts to

#[non_exhaustive] enum IcaChainId { Cosmos(TruncatedChainId), Evm(u64), }

@Kayanski @adairrr ?

@Kayanski
Copy link
Contributor

Kayanski commented Apr 28, 2025

Up for discussion: It seems more common to use chain id as number instead of chain-name for evm chains, do we want to replace TruncatedChainId parts to

#[non_exhaustive] enum IcaChainId { Cosmos(TruncatedChainId), Evm(u64), }

@Kayanski @adairrr ?

That's a good idea, Are we using this ICA Client for other purposes than EVM chains though ? Is it necessary to have Cosmos chains in there too ? We do have the IBC Client for that I think already ?
Otherwise, that's a very nice idea to have the ICA client work like the IBC client !

@Buckram123
Copy link
Collaborator Author

Up for discussion: It seems more common to use chain id as number instead of chain-name for evm chains, do we want to replace TruncatedChainId parts to

#[non_exhaustive] enum IcaChainId { Cosmos(TruncatedChainId), Evm(u64), }

@Kayanski @adairrr ?

That's a good idea, Are we using this ICA Client for other purposes than EVM chains though ? Is it necessary to have Cosmos chains in there too ? We do have the IBC Client for that I think already ? Otherwise, that's a very nice idea to have the ICA client work like the IBC client !

You are right, we're only using it for evm chains right now. It could be good to keep it as a multi-chain client as it has more functionality beyond helping evm executions and it is quite different from ibc client: each account controls it's own proxy on remote chain

@Buckram123 Buckram123 merged commit 1b0741c into main May 12, 2025
5 of 13 checks passed
@Buckram123 Buckram123 deleted the misha/abs-636-support-multiple-polytone-evm-connections-on-ica-client branch May 12, 2025 13:31
@Buckram123
Copy link
Collaborator Author

Up for discussion: It seems more common to use chain id as number instead of chain-name for evm chains, do we want to replace TruncatedChainId parts to

#[non_exhaustive] enum IcaChainId { Cosmos(TruncatedChainId), Evm(u64), }

@Kayanski @adairrr ?

That's a good idea, Are we using this ICA Client for other purposes than EVM chains though ? Is it necessary to have Cosmos chains in there too ? We do have the IBC Client for that I think already ? Otherwise, that's a very nice idea to have the ICA client work like the IBC client !

You are right, we're only using it for evm chains right now. It could be good to keep it as a multi-chain client as it has more functionality beyond helping evm executions and it is quite different from ibc client: each account controls it's own proxy on remote chain

Moved discussion into ABS-637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants