Skip to content

Feature/polya #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Feature/polya #12

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
83c16de
Add Polya prompting
Jun 18, 2025
8aadf97
Use update_msg to replace current message
Jun 18, 2025
d2a94d4
Update 'last message'
Jun 18, 2025
c49fc69
Merge branch 'main' into feature/polya
Jun 19, 2025
8dcd31c
Use selectone in read_msg
Jun 19, 2025
c7fb143
Merge branch 'hotfix/read_msg_selectone' into feature/polya
Jun 19, 2025
b472a03
Restore msg logic
Jun 19, 2025
3946292
Clarify that note cells could be created too
Jun 19, 2025
4cadadc
Fix repr
Jun 20, 2025
f3d6990
Improve repr of steps
Jun 20, 2025
a7a000c
Use item instead of selectone
Jun 20, 2025
3b9d6df
Revert to fetchone
Jun 20, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use selectone in read_msg
  • Loading branch information
Duane Milne committed Jun 19, 2025
commit 8dcd31c66ac43099d3d066a82a85dfcc4ff98b51
2 changes: 1 addition & 1 deletion dialoghelper/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def read_msg(n:int=-1, # Message index (if relative, +ve is downwards)
if not 0<=idx<len(ids): return None
else: idx = n
db = get_db()
return db.t.message.fetchone('sid=?', [ids[idx]])
return db.t.message.selectone('sid=?', [ids[idx]])

# %% ../nbs/00_core.ipynb
def _msg(
Expand Down
16 changes: 14 additions & 2 deletions nbs/00_core.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@
" if not 0<=idx<len(ids): return None\n",
" else: idx = n\n",
" db = get_db()\n",
" return db.t.message.fetchone('sid=?', [ids[idx]])"
" return db.t.message.selectone('sid=?', [ids[idx]])"
]
},
{
Expand Down Expand Up @@ -732,9 +732,21 @@
],
"metadata": {
"kernelspec": {
"display_name": "python3",
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
"language_info": {
"codemirror_mode": {
"name": "ipython",
"version": 3
},
"file_extension": ".py",
"mimetype": "text/x-python",
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.7"
}
},
"nbformat": 4,
Expand Down