refactor: reuse sort logic between Query and Aggregate #15818
+142 −129
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR refactors Aggregate.prototype.sort to reuse the sort argument parsing logic from Query.prototype.sort, addressing an existing TODO in lib/aggregate.js
I extracted the sort parsing logic into a new shared helper function castSort (located in lib/helpers/query/castSort.js) and updated both Query and Aggregate to use it.
This reduces code duplication and ensures consistent behavior between the two classes. As a side effect, Aggregate.prototype.sort now supports Map and Array arguments, matching the capabilities of Query.prototype.sort.
Examples
Aggregate.prototype.sort now supports Maps and Arrays of Arrays, which were previously only supported by Query.prototype.sort: