fix: pathsToSave should allow saving parent paths of whitelisted paths #15850
+96 −47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where pathsToSave would skip updates when a modified path was a parent of one of the whitelisted paths. As a result, valid updates were being ignored even though they should have been saved.
What Was Changed
In lib/model.js, the save method now checks whether the modified key is either:
a parent of a whitelisted path, or
a child of it.
If either condition matches, the path is correctly included in the delta.
Verification
Added a dedicated test file test/gh-paths-to-save.test.js to reproduce the issue and validate the fix.
Ran all existing tests (test/model.test.js) to confirm no regressions.
Verified that the new test passes:
gh-paths-to-save
✔ should allow saving parent paths of whitelisted paths (gh-issue)
This ensures that parent paths are now properly saved when related whitelisted paths are updated.