Skip to content

Conversation

@Arunjagan12
Copy link

@Arunjagan12 Arunjagan12 commented Jun 3, 2023

Related Issue(s)

CLoses #73

Proposed Changes

The color of the navbar and font of the production page's title has been changed.

Type of Change

  • Enhancement

Your Idea for Level (GSSoC)

  • Level 1
  • Level 2
  • Level 3

Screenshots (if applicable)

Screenshot (54)

Screenshot (55)

Additional Notes

@github-actions
Copy link

github-actions bot commented Jun 3, 2023

Thank you, @Arunjagan12, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇
Please make sure you have marked all the completed tasks as done. ✅
We appreciate your patience and contribution! 😀

@github-actions github-actions bot added the gssoc23 This is label for GirlScript Summer of Code 2023 label Jun 3, 2023
@praveenscience
Copy link
Member

Bro, do you really think this looks good? 🤔

Copy link
Member

@praveenscience praveenscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey just rethink the colours dude, nice effort, but the colour doesn't seem really good. We could pretty much stay with Dark Mode?

items={NavItems}
className="AppHeader"
>
GitHub ReadMe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use prettier.

<ContainerRow fluid={true}>
<div className="col-12">
<h1 className="display-4 AppHeading text-center">
<h1 className="display-4 AppHeading text-center font_shadows_into_light">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have - instead of _?

<div className="col-12">
<h1 className="display-4 AppHeading text-center pt-2 pb-4">
GitHub ReadMe: Elevating Your Projects &amp; Profile to New
<h1 className="display-4 AppHeading text-center pt-2 pb-4 font_shadows_into_light">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have - instead of _?

.AppHeading {
font-size: 1.5em;
}
.font_shadows_into_light {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have - instead of _?

@Arunjagan12
Copy link
Author

I thought this will be better.But, if u mention what to change I will change it accordingly

@Arunjagan12 Arunjagan12 closed this Jun 3, 2023
@Arunjagan12 Arunjagan12 reopened this Jun 3, 2023
@praveenscience
Copy link
Member

Let's look into other harmonious colours in the palette and and show me.

@AmanJain18
Copy link
Collaborator

AmanJain18 commented Jun 3, 2023

@Arunjagan12 Stick to colour that will suit dark mode, currently these bright and blue don't LGTM.

@Arunjagan12 Arunjagan12 closed this Jun 8, 2023
@AmanJain18 AmanJain18 removed the gssoc23 This is label for GirlScript Summer of Code 2023 label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants