Skip to content

feat: updated contribution guidelines #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat: updated contribution guidelines #619

wants to merge 3 commits into from

Conversation

@vedant-jain03
Copy link
Member

@vedant-jain03 vedant-jain03 commented Feb 19, 2022

Contributed by: @CircuitVerse/issues-team
Guided by: @Shivansh2407 @tachyons @ayan-biswas0412
@netlify
Copy link

netlify bot commented Feb 19, 2022 •
edited
Loading

✔️ Deploy Preview for vigilant-nightingale-2f57b2 ready!

🔨 Explore the source changes: 1125859

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-nightingale-2f57b2/deploys/621114b21ee4490008e01596

😎 Browse the preview: https://deploy-preview-619--vigilant-nightingale-2f57b2.netlify.app
@vedant-jain03 vedant-jain03 requested a review from a team February 19, 2022 15:30
ayan-biswas0412
ayan-biswas0412 suggested changes Feb 19, 2022
View reviewed changes
Copy link
Member

@ayan-biswas0412 ayan-biswas0412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments by Github Actions.
ayan-biswas0412
ayan-biswas0412 approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@ayan-biswas0412 ayan-biswas0412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @vedant-jain03 🎉
tachyons
tachyons requested changes Feb 20, 2022
View reviewed changes
Copy link
Member

@tachyons tachyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interactive book requires different contribution guidelines as it is primarily about digital circuit learning, so it is important to keep the existing guidelines
@vedant-jain03
Copy link
Member Author

vedant-jain03 commented Feb 22, 2022 •
edited
Loading

Interactive book requires different contribution guidelines as it is primarily about digital circuit learning, so it is important to keep the existing guidelines

@tachyons, Sir should we add some specific section into existing one such as:

  • Issue label
  • Pull request reviews
  • PR Labels
  • Community
@tachyons
Copy link
Member

tachyons commented Jun 12, 2022

We don't need that for the time being
@tachyons tachyons closed this Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@vedant-jain03 @tachyons @Kartikay304 @ayan-biswas0412