Specify null false for timestamps and pass id to exists? #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fix Rails 5 deprecation warning for not explicitly setting the null option for timestamps. Also moved other timestamps to use timestamps method This deprecation warning was introduced in rails/rails#16481
While waiting for this PR to get merged: alexrothenberg/ammeter#50
The warning is: ``` You are passing an instance of ActiveRecord::Base to `exists?`. Please pass the id of the object by calling `.id`. ```
mikeastock changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix Rails 5 deprecation warning for not explicitly setting the null option
for timestamps. Also moved other timestamps to use timestamps method.
This PR also changes passing id into
exists?This deprecation warning was introduced in rails/rails#16481