fix campability of keep-session.lua with mpv.app on macos #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| If mpv.app is initially launching mpv in idle and loading a file afterwards, then won't it also be launching mpv with an empty playlist? |
Author
Yes, but the playlist will always be empty due to the load function checks the playlist-count too early (at idle), the mpv.app gets the playlist after idle. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using keep-session.lua with mpv.app, mpv will first start with idle mode and then load the file via something like the
openFile:method ofNSApplicationDelegate, same as theopen -a mpv.app some_video.mkvcommand.So observe
playlist-countmaybe a better choice for campability?