Skip to content

Conversation

@hithwen
Copy link
Contributor

@hithwen hithwen commented Aug 30, 2021

No description provided.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! :)

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #10013 (94b35b7) into master (7cb583b) will decrease coverage by 0.40%.
The diff coverage is n/a.

Flag Coverage Δ
active_directory 100.00% <ø> (ø)
activemq_xml 82.31% <ø> (ø)
amazon_msk 87.94% <ø> (ø)
apache 95.43% <ø> (ø)
aspdotnet 93.87% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 83.95% <ø> (ø)
ceph 91.02% <ø> (ø)
cisco_aci 95.88% <ø> (ø)
consul 91.74% <ø> (ø)
coredns 96.36% <ø> (ø)
couch 95.19% <ø> (+0.36%) ⬆️
couchbase 81.45% <ø> (ø)
directory 94.70% <ø> (ø)
disk 91.15% <ø> (-0.49%) ⬇️
dns_check 94.00% <ø> (ø)
dotnetclr 100.00% <ø> (ø)
ecs_fargate 77.65% <ø> (ø)
elastic 88.54% <ø> (ø)
envoy 93.77% <ø> (+0.25%) ⬆️
etcd 93.09% <ø> (ø)
exchange_server 100.00% <ø> (ø)
external_dns 100.00% <ø> (ø)
fluentd 94.77% <ø> (ø)
gearmand 77.27% <ø> (+1.29%) ⬆️
gitlab 89.94% <ø> (ø)
gitlab_runner 90.32% <ø> (ø)
iis 93.01% <ø> (ø)
network 61.11% <ø> (-15.64%) ⬇️
pdh_check 97.77% <ø> (ø)
sqlserver 67.87% <ø> (-14.20%) ⬇️
tcp_check 88.83% <ø> (ø)
win32_event_log 86.03% <ø> (+0.28%) ⬆️
windows_service 95.83% <ø> (ø)
wmi_check 92.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mx-psi
Copy link
Member

mx-psi commented Aug 31, 2021

Should tokumx have a Python 3 classifier too? I think it is missing one

classifiers=[
'Development Status :: 5 - Production/Stable',
'Intended Audience :: Developers',
'Intended Audience :: System Administrators',
'Topic :: System :: Monitoring',
'License :: OSI Approved :: BSD License',
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
],

@hithwen hithwen merged commit f6b3e9e into master Aug 31, 2021
@hithwen hithwen deleted the js/fix-incorrect-classifiers branch August 31, 2021 09:15
@ofek
Copy link
Contributor

ofek commented Aug 31, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog integration/active_directory integration/activemq_xml integration/activemq integration/amazon_msk integration/apache integration/aspdotnet integration/btrfs integration/cacti integration/ceph integration/cisco_aci integration/consul integration/coredns integration/couch integration/couchbase integration/directory integration/disk integration/dns_check integration/dotnetclr integration/ecs_fargate integration/elastic integration/envoy integration/etcd integration/exchange_server integration/external_dns integration/fluentd integration/gearmand integration/gitlab_runner integration/gitlab integration/go_expvar integration/gunicorn integration/haproxy integration/hdfs_datanode integration/hdfs_namenode integration/http_check integration/iis integration/istio integration/kafka_consumer integration/kong integration/kube_dns integration/kube_proxy integration/kubelet integration/kubernetes_state integration/kyototycoon integration/lighttpd integration/linkerd integration/linux_proc_extras integration/mapreduce integration/marathon integration/mcache integration/mesos_master integration/mesos_slave integration/mongo integration/mysql integration/nagios integration/network integration/nfsstat integration/nginx integration/openldap integration/openstack integration/oracle integration/pdh_check integration/pgbouncer integration/php_fpm integration/postfix integration/postgres integration/powerdns_recursor integration/process integration/prometheus integration/rabbitmq integration/redisdb integration/riakcs integration/snmp integration/snowflake integration/solr integration/spark integration/sqlserver integration/squid integration/ssh_check integration/statsd integration/supervisord integration/system_core integration/system_swap integration/tcp_check integration/teamcity integration/tomcat integration/twemproxy integration/varnish integration/vault integration/voltdb integration/vsphere integration/win32_event_log integration/windows_service integration/wmi_check integration/yarn integration/zk qa/skip-qa Automatically skip this PR for the next QA

5 participants