- Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove US3 log collection note for README #11135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sarina-dd commented Jan 13, 2022
Fix log collection header from h5 to h4
apigirl previously approved these changes Jan 13, 2022
dujuku previously approved these changes Jan 18, 2022
Contributor Author
| Resolved the conflict, ready for final review! |
fanny-jiang previously approved these changes Jan 19, 2022
yzhan289 previously approved these changes Jan 19, 2022
Contributor
yzhan289 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, but otherwise LGTM
Co-authored-by: Andrew Zhang <31313038+yzhan289@users.noreply.github.com>
bd6c830 Contributor Author
| Thanks @yzhan289! I merged the fix. Can you merge? Looks like I'm blocked on my end. |
yzhan289 approved these changes Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog documentation integration/active_directory integration/activemq_xml integration/activemq integration/aerospike integration/airflow integration/ambari integration/apache integration/aspdotnet integration/azure_active_directory integration/azure_iot_edge integration/cassandra_nodetool integration/cassandra integration/ceph integration/cilium integration/citrix_hypervisor integration/clickhouse integration/cockroachdb integration/confluent_platform integration/consul_connect integration/consul integration/coredns integration/couch integration/druid integration/elastic integration/envoy integration/etcd integration/flink integration/fluentd integration/gearmand integration/gitlab integration/glusterfs integration/gunicorn integration/haproxy integration/harbor integration/hazelcast integration/hdfs_datanode integration/hdfs_namenode integration/hive integration/hivemq integration/ibm_db2 integration/ibm_mq integration/ibm_was integration/ignite integration/iis integration/istio integration/jboss_wildfly integration/journald integration/kafka_consumer integration/kafka integration/kong integration/kube_scheduler integration/kyototycoon integration/lighttpd integration/linkerd integration/mapr integration/mapreduce integration/marathon integration/marklogic integration/mcache integration/mesos_master integration/mesos_slave integration/mongo integration/mysql integration/nginx_ingress_controller integration/nginx integration/openldap integration/openshift integration/openstack_controller integration/openstack integration/pgbouncer integration/postfix integration/postgres integration/powerdns_recursor integration/presto integration/proxysql integration/rabbitmq integration/redisdb integration/rethinkdb integration/riak integration/scylla integration/singlestore integration/solr integration/sonarqube integration/sqlserver integration/squid integration/statsd integration/supervisord integration/teamcity integration/tenable integration/tomcat integration/twemproxy integration/varnish integration/vault integration/vertica integration/voltdb integration/yarn integration/zk
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the partial used to implement US3 log collection note. This note no longer is applicable.
Motivation
Jira request
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached