Skip to content

Conversation

@sarina-dd
Copy link
Contributor

@sarina-dd sarina-dd commented Jan 13, 2022

What does this PR do?

Removes the partial used to implement US3 log collection note. This note no longer is applicable.

Motivation

Jira request

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
 Fix log collection header from h5 to h4
@sarina-dd sarina-dd marked this pull request as ready for review January 13, 2022 18:46
@sarina-dd sarina-dd requested review from a team and anshumgargdd as code owners January 13, 2022 18:46
apigirl
apigirl previously approved these changes Jan 13, 2022
dujuku
dujuku previously approved these changes Jan 18, 2022
@sarina-dd
Copy link
Contributor Author

Resolved the conflict, ready for final review!

fanny-jiang
fanny-jiang previously approved these changes Jan 19, 2022
yzhan289
yzhan289 previously approved these changes Jan 19, 2022
Copy link
Contributor

@yzhan289 yzhan289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but otherwise LGTM

Co-authored-by: Andrew Zhang <31313038+yzhan289@users.noreply.github.com>
@sarina-dd sarina-dd dismissed stale reviews from yzhan289, fanny-jiang, dujuku, and apigirl via bd6c830 January 19, 2022 21:32
@sarina-dd
Copy link
Contributor Author

Thanks @yzhan289! I merged the fix. Can you merge? Looks like I'm blocked on my end.

@yzhan289 yzhan289 merged commit 3616496 into master Jan 19, 2022
@yzhan289 yzhan289 deleted the sarina/us3-note-removal branch January 19, 2022 22:22
@yzhan289 yzhan289 changed the title remove US3 log collection note Remove US3 log collection note for README Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog documentation integration/active_directory integration/activemq_xml integration/activemq integration/aerospike integration/airflow integration/ambari integration/apache integration/aspdotnet integration/azure_active_directory integration/azure_iot_edge integration/cassandra_nodetool integration/cassandra integration/ceph integration/cilium integration/citrix_hypervisor integration/clickhouse integration/cockroachdb integration/confluent_platform integration/consul_connect integration/consul integration/coredns integration/couch integration/druid integration/elastic integration/envoy integration/etcd integration/flink integration/fluentd integration/gearmand integration/gitlab integration/glusterfs integration/gunicorn integration/haproxy integration/harbor integration/hazelcast integration/hdfs_datanode integration/hdfs_namenode integration/hive integration/hivemq integration/ibm_db2 integration/ibm_mq integration/ibm_was integration/ignite integration/iis integration/istio integration/jboss_wildfly integration/journald integration/kafka_consumer integration/kafka integration/kong integration/kube_scheduler integration/kyototycoon integration/lighttpd integration/linkerd integration/mapr integration/mapreduce integration/marathon integration/marklogic integration/mcache integration/mesos_master integration/mesos_slave integration/mongo integration/mysql integration/nginx_ingress_controller integration/nginx integration/openldap integration/openshift integration/openstack_controller integration/openstack integration/pgbouncer integration/postfix integration/postgres integration/powerdns_recursor integration/presto integration/proxysql integration/rabbitmq integration/redisdb integration/rethinkdb integration/riak integration/scylla integration/singlestore integration/solr integration/sonarqube integration/sqlserver integration/squid integration/statsd integration/supervisord integration/teamcity integration/tenable integration/tomcat integration/twemproxy integration/varnish integration/vault integration/vertica integration/voltdb integration/yarn integration/zk

6 participants