Skip to content

Conversation

@FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jan 14, 2024

What does this PR do?

Fix incompatibility issues with Python 3.9 and lower

Motivation

The strict param was added in Python 3.10. The default value is false. A customer is trying to install the 16.0.0 wjheel on 7.50.2 and it's not working because of this

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
@FlorentClarret FlorentClarret force-pushed the florentclarret/py311_compatiblity branch from 922f20d to 79ca73e Compare January 14, 2024 10:18
@codecov
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba17944) 90.55% compared to head (79ca73e) 90.66%.
Report is 23 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
postgres 92.81% <100.00%> (+0.28%) ⬆️
presto ?
solr ?
teradata 94.06% <ø> (ø)
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

Test Results

   19 files     19 suites   20m 7s ⏱️
  327 tests   324 ✅   3 💤 0 ❌
2 296 runs  2 187 ✅ 109 💤 0 ❌

Results for commit 79ca73e.

@FlorentClarret FlorentClarret merged commit feb9b48 into master Jan 15, 2024
@FlorentClarret FlorentClarret deleted the florentclarret/py311_compatiblity branch January 15, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment