Skip to content

Conversation

@FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Jan 18, 2024

What does this PR do?

Remove deprecated tomcat.cache metrics

Motivation

Tomcat 7 EOLed 3 years ago and we do not have these metrics anymore.

Additional Notes

They are not tested anymore

datadoghq.atlassian.net/browse/AI-3731

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
@FlorentClarret
Copy link
Member Author

FlorentClarret commented Jan 18, 2024

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

@ghost ghost added the integration/tomcat label Jan 18, 2024
@codecov
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ef7e30) 90.43% compared to head (5c2d759) 90.52%.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat 63.63% <ø> (?)
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Jan 18, 2024

Test Results

12 files  12 suites   1m 3s ⏱️
 2 tests  2 ✅  0 💤 0 ❌
24 runs  12 ✅ 12 💤 0 ❌

Results for commit 5c2d759.

♻️ This comment has been updated with latest results.

Base automatically changed from florentclarret/tomcat/update_metrics to master January 18, 2024 09:51
@FlorentClarret FlorentClarret force-pushed the florentclarret/tomcat/remove_metrics branch from 080a8b9 to 5c2d759 Compare January 18, 2024 09:52
@FlorentClarret FlorentClarret marked this pull request as ready for review January 18, 2024 09:52
@FlorentClarret FlorentClarret requested a review from a team as a code owner January 18, 2024 09:52
@FlorentClarret FlorentClarret merged commit 7aafc79 into master Jan 18, 2024
@FlorentClarret FlorentClarret deleted the florentclarret/tomcat/remove_metrics branch January 18, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment