Skip to content

Fix wait_for_health argument in docker_run #21209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

Fix wait_for_health argument in docker_run #21209

merged 1 commit into from
Aug 29, 2025
+3 −0

Conversation

@AAraKKe
Copy link
Contributor

@AAraKKe AAraKKe commented Aug 29, 2025 •
edited
Loading

What does this PR do?

Fix the wait_for_health parameter in docker_run

Motivation

This was added back in #21104 but it was never made effective by mistake. This fixes it by passing the proper value to the compose command.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged
@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Aug 29, 2025
@AAraKKe AAraKKe requested review from a team as code owners August 29, 2025 16:16
@AAraKKe AAraKKe force-pushed the aarakke/fix-wait-for-health branch from df6dee6 to 0da03e7 Compare August 29, 2025 16:17
@AAraKKe AAraKKe force-pushed the aarakke/fix-wait-for-health branch from 0da03e7 to 1aad8cd Compare August 29, 2025 16:20
@AAraKKe AAraKKe added this pull request to the merge queue Aug 29, 2025
Merged via the queue into master with commit 17e34f8 Aug 29, 2025
44 checks passed
@AAraKKe AAraKKe deleted the aarakke/fix-wait-for-health branch August 29, 2025 16:22
github-actions bot pushed a commit that referenced this pull request Aug 29, 2025
@github-merge-queue
Fix wait_for_health argument in docker_run (#21209) 17e34f8
6aa446a
@codecov
Copy link

codecov bot commented Aug 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.95%. Comparing base (c9fb73d) to head (1aad8cd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev_package integration/mysql integration/openldap integration/pgbouncer integration/tomcat qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations team/database-monitoring-agent

3 participants

@AAraKKe @lucia-sb