Skip to content

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Oct 21, 2025

Motivation

This is a direct follow-up of:

... where a review comment rightfully suggested that:

Instead, we should run a normal single-arch Python distribution where everything will just work by default and we can remove the renaming logic. The source of distributions should be the python-build-standalone project which the makers of UV recently adopted. They are used by everyone nowadays, even rules_python.

What does this PR do?

The present change aims at embracing the above-recommended approach, which indeed looks simpler because the need for bundling targeted architectures is then addressed without additional environment variables, while still allowing delocate_wheel to verify architecture requirements.

Also, the PBS distribution happens to be pretty lightweight (16MB vs 71MB).

JSGette
JSGette previously approved these changes Oct 22, 2025
Copy link
Contributor

@JSGette JSGette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JSGette JSGette dismissed their stale review October 22, 2025 08:13

Wrong PR approved

@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/require-archs-on-macos-with-ofek-recommendation branch from a2711b7 to 77d35ca Compare October 22, 2025 21:13
@rdesgroppes rdesgroppes changed the title [WIP] Switch to "Python Build Standalone" Switch to Python Build Standalone for macOS wheels Oct 22, 2025
@rdesgroppes rdesgroppes added the qa/skip-qa Automatically skip this PR for the next QA label Oct 22, 2025
@rdesgroppes rdesgroppes marked this pull request as ready for review October 22, 2025 21:19
@rdesgroppes rdesgroppes requested review from a team as code owners October 22, 2025 21:19
@rdesgroppes rdesgroppes requested a review from ofek October 22, 2025 21:19
@rdesgroppes rdesgroppes requested a review from JSGette October 22, 2025 21:21
@iliakur iliakur self-assigned this Oct 27, 2025
iliakur
iliakur previously approved these changes Oct 27, 2025
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment, lgtm otherwise

iliakur
iliakur previously approved these changes Oct 27, 2025
@rdesgroppes
Copy link
Contributor Author

Looks good to me pending removal of the Claude comment!

Done in second commit (a4238c3).

@rdesgroppes rdesgroppes enabled auto-merge October 27, 2025 19:58
@rdesgroppes rdesgroppes requested review from a team and removed request for JSGette October 27, 2025 20:02
This is a follow-up of: - #21692 ... where a review comment rightfully suggested that: > Instead, we should run a normal single-arch Python distribution where > everything will just work by default and we can remove the renaming > logic. The source of distributions should be the > [python-build-standalone](https://github.com/astral-sh/python-build-standalone) > project which the makers of UV recently adopted. They are used by > everyone nowadays, even > [rules_python](https://github.com/bazel-contrib/rules_python/blob/cf594f780c91f13d48e77faad34df48ac57398da/python/versions.bzl#L29). The present change aims at embracing the above-recommended approach, which looks indeed promising because the need for bundling targeted architectures is then addressed without additional environment variables, while still allowing `delocate_wheel` to verify architecture requirements. Also, the PBS distribution happens to be pretty lightweight (16MB vs 71MB).
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/require-archs-on-macos-with-ofek-recommendation branch from a4238c3 to cbc0344 Compare December 4, 2025 09:12
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed iliakur’s stale review December 4, 2025 09:12

Review from iliakur is dismissed. Related teams and files:

  • agent-integrations
    • .github/workflows/resolve-build-deps.yaml
@rdesgroppes rdesgroppes added this pull request to the merge queue Dec 4, 2025
Any commits made after this event will not be merged.
@rdesgroppes
Copy link
Contributor Author

Thanks, guys!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 4, 2025
@rdesgroppes rdesgroppes added this pull request to the merge queue Dec 4, 2025
Any commits made after this event will not be merged.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 4, 2025
@rdesgroppes rdesgroppes added this pull request to the merge queue Dec 4, 2025
Any commits made after this event will not be merged.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 4, 2025
@rdesgroppes rdesgroppes added this pull request to the merge queue Dec 4, 2025
Any commits made after this event will not be merged.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 4, 2025
@rdesgroppes
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 4, 2025

View all feedbacks in Devflow UI.

2025-12-04 17:33:34 UTC ℹ️ Start processing command /merge
Use /merge -c to cancel this operation!


2025-12-04 17:33:40 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!


⏳ Processing

@rdesgroppes rdesgroppes added this pull request to the merge queue Dec 4, 2025
Any commits made after this event will not be merged.
github-merge-queue bot pushed a commit that referenced this pull request Dec 4, 2025
This is a follow-up of: - #21692 ... where a review comment rightfully suggested that: > Instead, we should run a normal single-arch Python distribution where > everything will just work by default and we can remove the renaming > logic. The source of distributions should be the > [python-build-standalone](https://github.com/astral-sh/python-build-standalone) > project which the makers of UV recently adopted. They are used by > everyone nowadays, even > [rules_python](https://github.com/bazel-contrib/rules_python/blob/cf594f780c91f13d48e77faad34df48ac57398da/python/versions.bzl#L29). The present change aims at embracing the above-recommended approach, which looks indeed promising because the need for bundling targeted architectures is then addressed without additional environment variables, while still allowing `delocate_wheel` to verify architecture requirements. Also, the PBS distribution happens to be pretty lightweight (16MB vs 71MB).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment