Skip to content

Conversation

@sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Nov 25, 2025

What does this PR do?

Adds ability to filter metrics by source command and stops collecting GPU metrics by default

Motivation

We want to be able to limit metric collection (ie if a command is not supported in a certain LSF version or environment, or if the metrics are not needed).
Additionally, the GPU commands are not available on lsf servers that do not have GPUs, so we don't want to always run them by default.

Note to reviewers: I ran into an issue in our config model generation that limits the amount of options in an enum. I will make a card for it and once it's fixed, remove the validator and make the metric_sources field an enum.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.05%. Comparing base (a3444d8) to head (eb7a101).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@github-actions
Copy link

⚠️ Major version bump
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@sarah-witt sarah-witt added this pull request to the merge queue Nov 25, 2025
Merged via the queue into master with commit 01942f6 Nov 25, 2025
60 of 61 checks passed
@sarah-witt sarah-witt deleted the sarah/add-ibm-filtering-metrics branch November 25, 2025 09:30
@sarah-witt sarah-witt changed the title Add ability to filter metrics and don't collect GPU metrics by default [AI-6308] Add ability to filter metrics and don't collect GPU metrics by default Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment