Skip to content

Update systemd dashboard #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2019
Merged

Update systemd dashboard #4240

merged 2 commits into from
Jul 31, 2019

Conversation

@AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Jul 30, 2019 •
edited
Loading

What does this PR do?

Update systemd dashboard by creating a new Dashboard.

Previous one was cloned from Presto, by doing so, some fields like source_type_id and board_id are copied along the way.

Lesson: do not clone an existing board when creating a new dashboard.

Additional Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.
@AlexandreYang AlexandreYang requested review from a team as code owners July 30, 2019 17:17
therve
therve approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@therve therve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting you on that one.
hithwen
hithwen reviewed Jul 31, 2019
View reviewed changes
systemd/assets/dashboards/overview.json
"modified": "2019-07-22T11:20:17.973450+00:00",
"new_id": "7nw-jch-7aw",
"modified": "2019-07-30T17:02:45.880897+00:00",
"new_id": "my7-n2s-zrw",
Copy link
Contributor

@hithwen hithwen Jul 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the ID need to change? If it has been already deployed to prod does this mean a new dashboard will be created?
Copy link
Member Author

@AlexandreYang AlexandreYang Jul 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not deployed yet, so should be safe.
@AlexandreYang AlexandreYang merged commit 785280d into master Jul 31, 2019
@AlexandreYang AlexandreYang deleted the alex/systemd_dashboard2 branch August 7, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog integration/systemd

4 participants

@AlexandreYang @therve @hithwen