fix: handle NoneType exception in installer dialog #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fix AttributeError when compat_tool is None by adding proper null checking before accessing the is_archive property. This prevents crashes when the compatibility tool object is not properly initialized. The error occurred because the code assumed compat_tool would always be a valid object with an is_archive property, but in some cases it can be None, leading to AttributeError exceptions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
| Closing - incorrect PR description |
Contributor
| For reference, you can edit a Pull Request title and description on GitHub without needing to close the PR. 🙂 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
compat_toolbefore accessing itsis_archivepropertyProblem
The code assumed
compat_toolwould always be a valid object with anis_archiveproperty, but in some cases it can be None, leading to AttributeError exceptions that crash the installer dialog.Solution
Added proper null checking using conditional expression to safely handle cases where
compat_toolis None, defaulting to False for the archive check.Test plan
🤖 Generated with Claude Code