Skip to content

Conversation

Copy link

Copilot AI commented Oct 15, 2025

Overview

This PR adds support for Node.js 24 to the bun-node repository, addressing issue #[issue_number]. Node.js 24 was released in May 2025 and will become an LTS release on October 28, 2025.

Changes

1. Added Node.js 24 to versions.json

Added a new entry for Node.js 24 with the latest available version:

"24": { "name": "v24", "version": "v24.10.0" }

Note: The codename is currently "v24" as Node.js 24 hasn't been assigned an official LTS codename yet. This can be easily updated once the LTS codename is announced.

2. Updated CI/CD workflow

Modified .github/workflows/release.yml to include Node.js 24 in the automated version checking:

NODE_MAJOR_VERSIONS_TO_CHECK: 18,20,22,23,24

This ensures that:

  • The daily scheduled job will check for Node.js 24 updates
  • New Node.js 24 versions will automatically trigger Docker image builds
  • Manual workflow dispatches can specify Node.js 24 versions

3. Enhanced test coverage

Updated test_check_nodejs.py to include Node.js 24:

  • Added v24.10.0 to the mock HTML data
  • Created a dedicated test case test_nodejs_24_support to validate Node.js 24 detection and version checking

Testing

All tests pass successfully:

  • ✅ 10 tests passed, 1 skipped
  • ✅ 91% code coverage maintained
  • ✅ Code review passed with no issues
  • ✅ Verified check_nodejs.py correctly handles Node.js 24
  • ✅ Confirmed build_updated.sh handles Node.js 24 through existing dynamic version detection

Compatibility

The existing build_updated.sh script already handles Node.js 24 automatically through its dynamic version detection from versions.json. No changes were needed to the build logic, as it reads the major version and codename dynamically using jq.

Docker Image Tags

With this change, the following new Docker image tags will be available:

  • imbios/bun-node:<bun-version>-24-<distro>
  • imbios/bun-node:<bun-version>-24.<minor>.<patch>-<distro>
  • imbios/bun-node:<bun-version>-v24-<distro>
  • imbios/bun-node:latest-24-<distro>
  • imbios/bun-node:latest-v24-<distro>

Future Considerations

Once Node.js 24 reaches LTS status (October 28, 2025) and receives its official codename, we can update the name field in versions.json from "v24" to the official codename (which will follow the pattern of previous releases: hydrogen, iron, jod, etc.).

Original prompt

This section details on the original issue you should resolve

<issue_title>[FEAT]: Support Node.js 24</issue_title>
<issue_description>### Clear and concise description of the problem

Since Node.js 24 will be LTS soon.

Suggested solution

No response

Alternative

No response

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the Contributing Guide.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #39


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2025

⚠️ No Changeset found

Latest commit: cce2489

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: ImBIOS <41441643+ImBIOS@users.noreply.github.com>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarQube Cloud

Copilot AI changed the title [WIP] Add support for Node.js 24 feat: Add Node.js 24 support Oct 15, 2025
Copilot AI requested a review from ImBIOS October 15, 2025 06:03
Copilot finished work on behalf of ImBIOS October 15, 2025 06:03
Copy link
Owner

@ImBIOS ImBIOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure 24 is successful and remove thos unsued

REGISTRY: imbios
PLATFORMS: linux/amd64,linux/arm64
NODE_MAJOR_VERSIONS_TO_CHECK: 18,20,22,23
NODE_MAJOR_VERSIONS_TO_CHECK: 18,20,22,23,24
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow what's in https://github.com/nodejs/docker-node
only 20, 22, 24 should left, the others should be deleted.

"canary": "v1.2.22-canary.20250918.1"
},
"nodejs": {
"24": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you at it, remove 18 and 23

@ImBIOS ImBIOS closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants