Drop support for Python 3.9 #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ndgrigorian requested review from antonwolfy, jharlow-intel and xaleryb as code owners Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes Python 3.9 support from mkl_fft, aligning with NumPy's deprecation of this Python version. The changes update package metadata and CI/CD configurations to reflect the new minimum supported version of Python 3.10.
- Removed Python 3.9 from package classifiers and version requirements
- Updated all CI/CD workflows to exclude Python 3.9 from test matrices
- Removed conditional logic specific to Python 3.9 compatibility issues
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Removed Python 3.9 classifier and updated minimum required version to 3.10 |
| .github/workflows/conda-package.yml | Removed Python 3.9 from test matrices and eliminated conditional scipy installation logic |
| .github/workflows/conda-package-cf.yml | Removed Python 3.9 entries from test matrix configurations |
| .github/workflows/build_pip.yaml | Removed Python 3.9 from build test matrix |
| .github/workflows/build-with-clang.yml | Removed Python 3.9 from clang build test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ndgrigorian force-pushed the drop-python-3.9 branch from 68e1a41 to 35f3cb3 Compare ndgrigorian force-pushed the drop-python-3.9 branch from 5906c4c to f937387 Compare 
antonwolfy reviewed Oct 30, 2025
antonwolfy reviewed Oct 31, 2025
Collaborator
antonwolfy left a comment
antonwolfy left a comment There was a problem hiding this comment.
Thank you @ndgrigorian
Collaborator Author
| @antonwolfy |
antonwolfy approved these changes Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR proposes dropping Python 3.9 support from mkl_fft, as it has long been unsupported by NumPy