This repository was archived by the owner on Feb 4, 2025. It is now read-only.
[Feature] OAuth 2 #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| CURRENT_USER("/users/@me"), | ||
| CURRENT_USER_GUILDS("/users/@me/guilds"); | ||
| // We always use the same rest version as JDA | ||
| public static final String BASE_API_URL = String.format("https://discordapp.com/api/v%d", JDAInfo.DISCORD_REST_VERSION); |
Member
There was a problem hiding this comment.
This is dangerous as JDA's rest version can change without notice
Shengaero added Enhancement 
Contributor
| Can I volunteer to test this? |
Update OAuth2 branch
duncte123 reviewed May 30, 2018
| { | ||
| obj = body.getJSONObject(i); | ||
| list.add(new OAuth2GuildImpl(OAuth2ClientImpl.this, obj.getLong("id"), | ||
| obj.getString("name"), obj.getString("icon"), obj.getBoolean("owner"), |
Contributor
There was a problem hiding this comment.
Isn't it better to use obj.optString("icon", nul) because the server icon can be null and it will throw this error:
org.json.JSONException: JSONObject["icon"] not a string. at org.json.JSONObject.getString(JSONObject.java:810) at com.jagrosh.jdautilities.oauth2.entities.impl.OAuth2ClientImpl$3.handle(OAuth2ClientImpl.java:185) at com.jagrosh.jdautilities.oauth2.entities.impl.OAuth2ClientImpl$3.handle(OAuth2ClientImpl.java:165) at com.jagrosh.jdautilities.oauth2.requests.OAuth2Requester.submitSync(OAuth2Requester.java:95) at com.jagrosh.jdautilities.oauth2.requests.OAuth2Action.complete(OAuth2Action.java:147) Collaborator
There was a problem hiding this comment.
Fixed with merge of #67
Thanks for the help @duncte123! 😃
* Use optString for the guild icon because it can be null * Use null as default
…A-Applications/JDA-Utilities into feature/oauth2 # Conflicts: # settings.gradle
…A-Applications/JDA-Utilities into feature/oauth2 # Conflicts: # settings.gradle
Change file extension of guild icon to reflect jda's change
Contributor
| This branch is currently 100% broken due to discord requiring the params for the token request to be set as post fields instead of get params, will be fixed when #92 is merged |
Update oauth2 to JDAv4
Contributor
| Since this still has the "needs testing" label I'd like to say that I've been running this branch for a while now in production and it's been working fine, it can be seen in action over here |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.