Fix bug #1041 #1217 #1361
Merged
Fix bug #1041 #1217 #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor Author
| anybody help with the github actions. It says: Error: The process '/usr/bin/git' failed with exit code 1 |
Contributor Author
| @KevinVandy Could you please fix the github action error, I have no idea how. thx |
KevinVandy approved these changes Feb 14, 2025
jonathanl-dropit pushed a commit to dropit-dev/material-react-table that referenced this pull request Jun 22, 2025
…ing fixes (KevinVandy#1361) * fix: KevinVandy#1041, KevinVandy#1217, wrong draggingRowIndex in virtual when filtered. * docs: add docs of wyh should do a extra index of rangeExtractor * chore: add vscode launch.json for debug storybook * Delete .vscode/launch.json * fix: draggingRowIndex should depend on realRows --------- Co-authored-by: 章勇 <zhangyong@zhangyong.com>
kabaniery pushed a commit to kabaniery/material-react-table that referenced this pull request Nov 20, 2025
…ing fixes (KevinVandy#1361) * fix: KevinVandy#1041, KevinVandy#1217, wrong draggingRowIndex in virtual when filtered. * docs: add docs of wyh should do a extra index of rangeExtractor * chore: add vscode launch.json for debug storybook * Delete .vscode/launch.json * fix: draggingRowIndex should depend on realRows --------- Co-authored-by: 章勇 <zhangyong@zhangyong.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As in bug #1041 and #1217 described. When filtered, we cannot just use
draggingRow?.indexforrangeExtractor, we should find the correct dragging row index in filtered rows.