Block cipher test after psa init 3.6 #10410
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
* Rename the suite containing dynamic dispatch tests. * Duplicate the suite containing test vectors and invalid scenarios: there will be one suite with PSA not initialized (as is the case today), and one new suite suite with PSA initialized. The distinction will be made in a subsequent commit. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
The job of the block_cipher module is to dispatch to either legacy code or PSA, depending on whether PSA is initialized. We were only testing the PSA-not-initialized legacy dispatch, except in the few dynamic dispatch test cases. Run the invalid-input and test vectors with PSA initialized as well. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm added component-crypto 
github-project-automation bot moved this to In Development in Non-roadmap pull requests 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
test_suite_block_cipherwas mostly testing the (rare in practice) PSA-not-initialized case. Also test the PSA-initialized case.Probably not a significant test gap since
block_cipheris an internal module, and higher-level tests should ensure that everything is fine with API functions.I noticed while working on Mbed-TLS/TF-PSA-Crypto#466 (review).
PR checklist