Skip to content

Remove use of pk_debug() #10517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

Remove use of pk_debug() #10517

wants to merge 5 commits into from
+54 −369

Conversation

@valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Nov 19, 2025

Description

Resolves #10460.
Depends on Mbed-TLS/TF-PSA-Crypto#577.

PR checklist
@valeriosetti
tf-psa-crypto: update reference
94a5f63 
Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti
library: debug: remove mbedtls_debug_print_mpi()
81bfb58 
This function is no more used anywhere and can be safely removed. Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti
library: debug: use mbedtls_pk_write_pubkey_psa() to write public key
f62812d 
Remove usage of mbedtls_pk_debug stuff and related functions (mbedtls_debug_print_psa_rsa(), mbedtls_debug_print_psa_ec(), mbedtls_debug_print_integer() and debug_count_valid_bits()) and use mbedtls_pk_write_pubkey_psa() to get the public key from the PK context. Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti valeriosetti added needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Nov 19, 2025
@valeriosetti
library: debug: improve mbedtls_debug_print_buf()
30f2db0 
Move single line printing to a separate function named mbedtls_debug_print_buf_one_line(). This accepts one extra parameter 'add_text' to tell if the final text chars are to be printed at the end of the line or not. Add also mbedtls_debug_print_buf_ext() as a generalized version of mbedtls_debug_print_buf() by adding the extra 'add_text' param. debug_print_pk() will now use mbedtls_debug_print_buf_ext() in order not to print chars while dumping the buffer. Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
@valeriosetti
tests: scripts: adjust CRT dump test data
bf030c5 
Adjust dumping format of public keys following recent updates to mbedtls_debug_print_crt() and debug_print_pk() Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)

1 participant

@valeriosetti