Skip to content

Conversation

@pd-reg-braithwaite
Copy link
Contributor

@pd-reg-braithwaite pd-reg-braithwaite commented Oct 31, 2022

Changes

Remove "hero" image

motivation

Although other pages in the response docs have hero images:

Who's on Call

The existing pages underneath "During an Incident" do not:

During an Incident

Security Incident

changes made

Consistent with these pages, External Communications Guidelines (1) no longer has a hero image (2), and it now has a brief introductory paragraph (3).

External Communications Guidelines

Add Heading Navigation

motivation

Existing pages are structured such that the navigation permits jumping either to the top of a page (1) or the top-level headings within the page (2):

Different Roles

changes made

Consistent with this practice, External Communication Guidelines now permits linking to the top of the page (1) and to the top-level headings within the page (2):

External Communication Guidelines

Copy link

@wlonkly wlonkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from the "code matches the description of changes" perspective. I'll leave it to the community team to verify that the contents of the change are what we wanted though!

@pd-reg-braithwaite pd-reg-braithwaite merged commit 784b16e into master Nov 1, 2022
@pd-reg-braithwaite pd-reg-braithwaite deleted the pd-reg-braithwaite-nav-update branch November 1, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants