Refactor instance creation #4389
Open
+727 −791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Trial97 force-pushed the refactor_instance_creation branch from 60ebd9f to 9cf2b48 Compare Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
Trial97 force-pushed the refactor_instance_creation branch from 9cf2b48 to a37d84e Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This removes QEventLoop from instance creation and simplifies a bit the abstractizations that happened there(like there is no need for 2 intermediate classes between the most basic one and the actual implementation)
Second commit is just me fighting against snake_case in favor of camelCase.