refactor(combine-latest): simplify logic by removing redundant loops … #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…and improving docs - Removed two unnecessary nested loops, reducing complexity and improving performance - Replaced mutable list flags with `nonlocal` variables for cleaner state handling - Added fallback `threading.RLock()` when `parent.lock` is not present - Improved type hints using generics (`TypeVar`, `Tuple[T, ...]`) - Added input validation to raise `ValueError` when no sources are provided - Expanded and standardized docstring (PEP 257 + NumPy style)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
nonlocalvariables for cleaner state handlingthreading.RLock()whenparent.lockis not presentTypeVar,Tuple[T, ...])ValueErrorwhen no sources are provided