Fix the quick return code in Eigen subroutines #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…C/ZHEEVX, S/DSYEVX, C/ZHPEVX, S/DSPEVX, C/ZHPGVX. 1. set RCONDE and RCONDV in S/D/C/ZGEESX when N = 0. 2. set Q in C/ZHBEVX, S/DSBEVX when N = 1 and WANTZ. 3. set IFAIL in C/ZHBEVX, S/DSBEVX, C/ZHEEVX, S/DSYEVX, C/ZHPEVX, S/DSPEVX when N = 1 and WANTZ. 4. set M in C/ZHPGVX when N = 0.
angsch reviewed Jun 23, 2025
Collaborator
angsch left a comment
angsch left a comment There was a problem hiding this comment.
I am generally positive about the changes. However, there are a couple of data type mismatches. Could you please do another sweep and ensure that the assigned values match?
Out of curiosity, what made you look at these corner cases?
| * | ||
| IF( N.EQ.0 ) THEN | ||
| SDIM = 0 | ||
| IF (WANTSE .OR. WANTSB) RCONDE = 1.0E0 |
Collaborator
There was a problem hiding this comment.
Why not RCONDE = ONE? (same question for other precisions)
| IF( N.EQ.0 ) THEN | ||
| SDIM = 0 | ||
| IF (WANTSE .OR. WANTSB) RCONDE = 1.0E0 | ||
| IF (WANTSV .OR. WANTSB) RCONDV = 0.0E0 |
Collaborator
There was a problem hiding this comment.
RCONDV = ZERO? (same question for other precisions)
| IF( WANTZ ) | ||
| $ Z( 1, 1 ) = CONE | ||
| IF( WANTZ ) THEN | ||
| Q( 1, 1 ) = ONE |
Collaborator
There was a problem hiding this comment.
To have matching types: ONE -> CONE
Please also check precision 'z'.
| $ Z( 1, 1 ) = CONE | ||
| IF( WANTZ ) THEN | ||
| Q( 1, 1 ) = ONE | ||
| Z( 1, 1 ) = ONE |
| IF( WANTZ ) | ||
| $ Z( 1, 1 ) = CONE | ||
| IF( WANTZ ) THEN | ||
| Z( 1, 1 ) = ONE |
| IF( WANTZ ) THEN | ||
| Q( 1, 1 ) = ONE | ||
| Z( 1, 1 ) = ONE | ||
| IFAIL(1) = ZERO |
Collaborator
There was a problem hiding this comment.
To have matching types: IFAIL(1) = 0 (more occurrences in other files)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fix the quick return code for S/D/C/ZGEESX, C/ZHBEVX, S/DSBEVX, C/ZHEEVX, S/DSYEVX, C/ZHPEVX, S/DSPEVX, C/ZHPGVX.
Checklist