Testing #45
Merged
Testing #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Thanks Julien. |
frazar added a commit to frazar/lapack that referenced this pull request Mar 3, 2020
The comment was introduce due to issue Reference-LAPACK#17. The comment ought to be deleted with PR Reference-LAPACK#22. However, this PR was superseded by PR Reference-LAPACK#45, which addressed the tests issue but did not remove the comment.
frazar added a commit to frazar/lapack that referenced this pull request Mar 3, 2020
The comment was introduced due to issue Reference-LAPACK#17. The comment ought to be deleted with PR Reference-LAPACK#22. However, this PR was superseded by PR Reference-LAPACK#45, which addressed the tests issue but did not remove the comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #17 and supercedes #22
Also 48a4a89 fixes the options values definition in the cache because they were not defined when first used.