Player Statistics

[Burbulinis]

Description

This PR aims to add player statistics and closes the beloved and old issue #4687! Here's a slight glimpse of how statistics will look like:

set {_int value} to statistic leave game statistic of player # returns an int, but eh... 'played time of player' exists set {_play time} to statistic ticks played statistic of player # or set {_play time} to statistic play one minute statistic of player # here comes some fun set {_usage count} to statistic use item statistic for grass block of player set {_pig kill count} to statistic kill entity statistic for a pig of player on player statistic increase: send "Wow! The %event-statistic% increased! It's now %future statistic value%" on player statistic increase of use item statistic: send event-itemtype on player statistic increase of leave game statistic: broadcast "wow... %player% left for the %future statistic value%th time..."

---

Target Minecraft Versions: any
Requirements: none
Related Issues: #4687

[sovdeeth]

I think the strings should be parsed into actual Statistics whenever possible, for faster comparison and to allow proper errors.
Which leads to asking why they're strings to begin with? Why not just an enum classinfo? jump statistic, walk one cm stat, etc

[Burbulinis]

I think the strings should be parsed into actual Statistics whenever possible, for faster comparison and to allow proper errors. Which leads to asking why they're strings to begin with? Why not just an enum classinfo? jump statistic, walk one cm stat, etc

I have made them actual enums now. My initial thought was that they should be strings, because there's a lot of enums. But I've looked at the default lang file and I saw that there are even more (of other enums) compared to statistics.

[TheLimeGlass]

This whole class should be an EventValueExpression. What you do is register the numbers as event values TIME_FUTURE and TIME_PAST then the EventValueExpression will automatically be able to grab the future and past values. This is because there is already a syntax for future and past in ExprEventValue

[Burbulinis]

I've already tried that (if you specifically mean registering the event value within the event), but it didn't work.
I registered the event value for an integer, a number and neither past/future event-integer or event-number worked

edit: I also prefer this expression over event-number because just by looking at event-number i cannot know what it is

[sovdeeth]

I'd like to re-open this a bit because Lime is correct that a EVE would be more appropriate, since then you use setTime to control past/future automatically. However, I think that would leave the syntax as statistic [value] which would interfere with the classinfo itself. That said, statistic value is a less ambiguous name and doesn't conflict at all, which I think I would prefer to see.

[Burbulinis]

i have no clue what happened to tests

[sovdeeth]

Suggested change

	"player statistic (change|increase|increment) [of %-statistics% statistic[s]]",
	"player statistic (change|increase|increment) [of %-statistics% statistic[s]]",

[sovdeeth]

I'd like to re-open this a bit because Lime is correct that a EVE would be more appropriate, since then you use setTime to control past/future automatically. However, I think that would leave the syntax as statistic [value] which would interfere with the classinfo itself. That said, statistic value is a less ambiguous name and doesn't conflict at all, which I think I would prefer to see.

[sovdeeth]

Suggested change

	private boolean shouldStop(Statistic statistic, Object ofType) {
	private boolean checkTyping(Statistic statistic, Object ofType) {

some short javadocs for this method and the others would be nice

[sovdeeth]

Do you still intend to work on this?