Implement time manipulation using JWT::leeway while validating nbf & exp #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It's available since branch 3.x cf https://github.com/firebase/php-jwt/blob/v3.0.0/src/JWT.php#L102 and well documented at https://github.com/firebase/php-jwt#example
lutangar added a commit to larriereguichet/oauth2-azure that referenced this pull request Mar 9, 2023
…tion This allows time manipulation for testing purpose. > as seen in TheNetworg#178, see https://github.com/firebase/php-jwt/blob/3b454f90f147db65a615041dec6661f427d6cb00/tests/JWTTest.php#L79-L90 for a usecase in testing
| Hi, is this something than can be merged as this is a very needed feature. |
Member
| Thank you, this is now merged. If no issues raise from this, I will proceed to create a release with this next week. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It's available since branch 3.x cf https://github.com/firebase/php-jwt/blob/v3.0.0/src/JWT.php#L102 and well documented at https://github.com/firebase/php-jwt#example