Add BDS link styles and update existing link styles #3401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
AKCodez commented Dec 2, 2025
AKCodez commented - Introduced new styles for BDS link icons, including hover and focus states.
- Updated existing link styles to exclude BDS links from certain color and hover effects.
- Ensured consistent styling across light and dark themes for BDS links.
- Refactored landing page link styles to accommodate new BDS link classes.
- Introduced new styles for BDS link icons, including hover and focus states. - Updated existing link styles to exclude BDS links from certain color and hover effects. - Ensured consistent styling across light and dark themes for BDS links. - Refactored landing page link styles to accommodate new BDS link classes.
Calvinjwala requested changes Dec 2, 2025
Collaborator
Calvinjwala left a comment
Calvinjwala left a comment There was a problem hiding this comment.
Looks great minus one TS error.
shared/components/Link/index.ts Outdated
| @@ -0,0 +1,5 @@ | |||
| export { Link } from './Link'; | |||
| export type { LinkProps, LinkVariant, LinkSize, LinkColor, LinkIconType } from './Link'; | |||
Collaborator
There was a problem hiding this comment.
🚫 Must fix: LinkColor is throwing an error. looks like type doesn't exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.