fix(transport): clone headers when creating a request #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| LGTM (we paired on this fix). Those tests appear unrelated (they seem to be flakey). I've tried to correct this before (#741) but didn't get very far. We should look into this on a separate issue. |
dhowden approved these changes Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Describe your change
This change clones the http headers when making a new http request. Previously the same instance of the header map would be used for all requests.
What problem is this fixing?
This fixes a panic due to concurrent map write that can occur if you have a custom
transport.Requesterthat adds additional headers to the request.