Exporting Path Dispatch to a standalone repository #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mogmarsh approved these changes Feb 7, 2023
Contributor
mogmarsh left a comment
mogmarsh left a comment There was a problem hiding this comment.
nice to see this as a package! 👍
| } | ||
| | ||
| if ( ! empty( $args['path'] ) ) { | ||
| if ( ! empty( $args['rewrite'] ) ) { |
Contributor
There was a problem hiding this comment.
I know this code has been around forever and works great, but I wonder if setting a variable to $args['path'] would make some of the code in this if more readable. Totally not necessary, though.
Co-authored-by: Greg Marshall <mogmarsh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.