Skip to content

Make sure variable is defined #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2024
Merged

Make sure variable is defined #4

merged 2 commits into from
May 1, 2024

Conversation

@dlh01
Copy link
Member

@dlh01 dlh01 commented Nov 7, 2023

It can happen that $args never gets defined when the dispatch query variable isn't the same as the path argument — in the example below, when prefixing the query variable:

add_path(	[	'path' => 'foo',	'rewrite' => [	'rule' => 'foo/?$',	'redirect' => 'index.php?dispatch=my_foo',	],	], );
mogmarsh
mogmarsh approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@srtfisher srtfisher merged commit e332b9a into develop May 1, 2024
@srtfisher srtfisher deleted the fix/undefined branch May 1, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@dlh01 @mogmarsh @srtfisher